Fix #537, Fail tests on startup and tear down failures #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rushed this one... not ready. |
skliper
force-pushed
the
fix537-ut-fail-on-tsf
branch
2 times, most recently
from
1f4ccd0 to
c8c2bcd
Compare
skliper
added
CCB:Ready
|
CCB 2020-08-26 - Needs the test failure to be fixed (which might have already happened), APPROVED |
yammajamma
added
CCB-20200826
and removed
CCB:Ready
This was referenced Aug 27, 2020
|
@skliper is the only thing missing is to try this against the bundle? |
|
I don't think anything is missing. This is ready. |
|
I can rebase if you want to see the failure go away. |
|
That would be lovely |
skliper
force-pushed
the
fix537-ut-fail-on-tsf
branch
from
c8c2bcd to
a5a0183
Compare
|
@astrogeco @yammajamma - rebased on IC and now it passes. Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #537 - fail tests on startup or tear down failures... these are failures, just a different severity (likely mean the test didn't work as expected and needs to be fixed)
Testing performed
Built tests with a known startup failure, test failed as expected
Expected behavior changes
Now will fail on startup/tear down failures
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC