Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UtAssert_Zero in utassert.h doxygen brief incorrectly states nonzero #598

Closed
asgibson opened this issue Sep 14, 2020 · 0 comments · Fixed by #714 or #744
Closed

UtAssert_Zero in utassert.h doxygen brief incorrectly states nonzero #598

asgibson opened this issue Sep 14, 2020 · 0 comments · Fixed by #714 or #744
Labels
docs unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone

Comments

@asgibson
Copy link
Contributor

Describe the bug
What appears to be a copy paste error, the assert zero states it is checking for nonzero. This mimics the assert nonzero brief above it.

To Reproduce

* \brief Confirm an integer value is nonzero
*/
#define UtAssert_NONZERO(actual) do \
{ \
long val = (long)(actual); \
UtAssert_True(val != 0, "%s (%ld) != 0", \
#actual, val); \
} while(0)
/**
* \brief Confirm an integer value is nonzero
*/
#define UtAssert_ZERO(actual) do \
{ \
long val = (long)(actual); \
UtAssert_True(val == 0, "%s (%ld) == 0", \
#actual, val); \
} while(0)

Expected behavior
State "Confirm an integer value is zero" instead.

Code snips
see above.

System observed on:
N/A

Additional context
N/A.

Reporter Info
Alan Gibson NASA GSFC/587

@asgibson asgibson added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Sep 14, 2020
skliper added a commit to skliper/osal that referenced this issue Dec 29, 2020
astrogeco added a commit that referenced this issue Jan 6, 2021
Fix #598, Correct UtAssert_ZERO description typo
@astrogeco astrogeco added the docs label Jan 7, 2021
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Fix nasa#295, Resolve app table scanning race conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
3 participants