osal Integration Candidate: 2021-01-05 #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change sem flush to solve race condition change port numbers to be different from network test
Fix #726, Resolve user's guide generation warnings
Fix #730, Suppress invalid redundantAssignment warning from cppcheck
Fix #574, Document UtAssert_Message parameters
Fix #598, Correct UtAssert_ZERO description typo
Fix #740, Re-add automated static code analysis
Fix #707 change sem flush to solve race condition
Fix #712, Replace UT_OS_LOG with UtPrintf
astrogeco
changed the title
astrogeco
force-pushed
the
integration-candidate
branch
from
dd1a0b7 to
ab8f965
Compare
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 7, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 7, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #574, Document UtAssert_Message parameters
Fix #598, Correct UtAssert_ZERO description typo`
Fix #707, Resolve issues of auto tests in parallel build
Fix #726, Resolve user's guide generation warnings
Testing performed
See Github Actions https://github.com/nasa/cFS/pull/172/checks
Expected behavior changes
PR #713 - Document UtAssert_Message parameters, also adds "see also" note for helper macros.
PR #714 - Fix doxygen typo
PR #721 - Replace
OS_BinSemFlushwithOS_BinSemGiveto prevent a rare race condition. Change the port numbers to be different from network test for when tests are run in parallel.PR #728 - Fix doxygen format errors. Usersguide now builds without warnings.
PR #731 - Suppress invalid cppcheck warning in
OS_WaitForStateChangePR #741 - Add cppcheck static analysis workflow to osal CI
System(s) tested on
Ubuntu 18.04
Additional context
Part of nasa/cFS#172
Third party code
none
Contributor Info - All information REQUIRED for consideration of pull request
@skliper
@zanzaben
@astrogeco