Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample App has error counter and command counter reversed #25

Closed
jphickey opened this issue Nov 21, 2019 · 1 comment · Fixed by #34
Closed

Sample App has error counter and command counter reversed #25

jphickey opened this issue Nov 21, 2019 · 1 comment · Fixed by #34
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@jphickey
Copy link
Contributor

Describe the bug
The SAMPLE_ReportHousekeeping function reports the error count and command count values reversed.

To Reproduce
Send a NOOP command, then report housekeeping, and see that the error count is in place of the the command count.

Expected behavior
The error count and command count should not be reversed.

Code snips

Inside SAMPLE_ReportHousekeeping(), it has:

    Sample_AppData.SAMPLE_HkTelemetryPkt.sample_command_error_count = Sample_AppData.CmdCounter;
    Sample_AppData.SAMPLE_HkTelemetryPkt.sample_command_count = Sample_AppData.ErrCounter;

System observed on:
Ubuntu 18.04 LTS 64-bit

Additional context
Actually discovered this when writing the unit test for the ReportHousekeeping function (#8), and the test case failed because the counters were backwards.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

jphickey added a commit that referenced this issue Nov 21, 2019
These were being copied to the telemetry packet
backwards.  Trivial fix.
@skliper skliper added bug Something isn't working good first issue Good for newcomers labels Nov 28, 2019
@skliper
Copy link
Contributor

skliper commented Nov 30, 2019

@jphickey Is the referenced commit ready for a pull request (or did I miss it)?

skliper pushed a commit that referenced this issue Dec 30, 2019
These were being copied to the telemetry packet
backwards.  Trivial fix.
@skliper skliper added this to the 1.2.0 milestone Dec 30, 2019
skliper added a commit that referenced this issue Dec 30, 2019
Fix #23, #25, #28, #30
Reviewed and approved at 2019-12-18 CCB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants