Fix #28: Check return of CFE_TBL_GetAddress #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code must not dereference the pointer unless the call returned CFE_SUCCESS, otherwise the pointer is not valid.
skliper
approved these changes
Dec 17, 2019
|
CCB 20191218 - Reviewed and approved for IC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #28.
The code must not dereference the pointer unless the call returned CFE_SUCCESS, otherwise the pointer is not valid.
Testing performed
Execute CFE under simulation, send ProcessCC command and ensure no change to nominal behavior
Expected behavior changes
No change in the nominal case, where the command operates normally and the table address is valid.
The SAMPLE_ProcessCC function now does not dereference the table pointer in case the CFE_TBL_GetAddress function fails, which is confirmed in the unit test.
System(s) tested on:
Ubuntu 18.04 LTS, 64-bit
Contributor Info
Joseph Hickey, Vantage Systems, Inc.
Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted