Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #128, Standardize naming of SCH_LAB functions/macros #129

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix #128, Standardize naming of SCH_LAB functions/macros #129

merged 1 commit into from
Nov 14, 2023

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Oct 16, 2022 •
edited
Loading

Checklist

Describe the contribution

Also requires a change to the cfe startup script

Testing performed
Only GitHub CI workflow actions.

Expected behavior changes
No impact on behavior.

Contributor Info
@thnkslprpt

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 16, 2022
View reviewed changes
fsw/src/sch_lab_app.c
@@ -72,7 +72,7 @@
/*
** AppMain
*/
void SCH_Lab_AppMain(void)
void SCH_LAB_AppMain(void)

Check notice

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
fsw/src/sch_lab_app.c
@@ -72,7 +72,7 @@
/*
** AppMain
*/
void SCH_Lab_AppMain(void)
void SCH_LAB_AppMain(void)

Check notice

Code scanning / CodeQL-coding-standard

Function too long Note

SCH_LAB_AppMain has too many lines (69, while 60 are allowed).
This was referenced Oct 16, 2022
Open
Open
@thnkslprpt thnkslprpt force-pushed the fix-128-standarize-naming branch from 1633247 to 80971cf Compare October 16, 2022 11:35
@thnkslprpt thnkslprpt mentioned this pull request Oct 16, 2022
Open
2 tasks
@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
jphickey
jphickey approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup, we should (finally) merge this too

@jphickey jphickey force-pushed the fix-128-standarize-naming branch from 80971cf to 18b9795 Compare November 2, 2023 16:16
@dzbaker dzbaker mentioned this pull request Nov 13, 2023
Merged
2 tasks
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 13, 2023
@dzbaker
IC: Caelum-rc4+dev64
4af773f 
*Combines:*

sch_lab v2.5.0-rc4+dev71
sample_app v1.3.0-rc4+dev65
to_lab v2.5.0-rc4+dev66
ci_lab v2.5.0-rc4+dev69
cFE v7.0.0-rc4+dev411
PSP v1.6.0-rc4+dev96

**Includes:**

*sch_lab*
- nasa/sch_lab#129
- nasa/sch_lab#149
- nasa/sch_lab#142
- nasa/sch_lab#134

*sample_app*
- nasa/sample_app#212
- nasa/sample_app#187
- nasa/sample_app#190

*to_lab*
- nasa/to_lab#168
- nasa/to_lab#134
- nasa/to_lab#146
- nasa/to_lab#148
- nasa/to_lab#152
- nasa/to_lab#158
- nasa/to_lab#163

*ci_lab*
- nasa/ci_lab#152
- nasa/ci_lab#153

*cFE*
- nasa/cFE#2462
- nasa/cFE#2408

*PSP*
- nasa/PSP#417

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Isaac Rowe <irowebbn@users.noreply.github.com>
Co-authored by: Jacob Hageman  <skliper@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Nov 13, 2023
Merged
2 tasks
@dzbaker dzbaker merged commit 1a0dbdd into nasa:main Nov 14, 2023
11 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 14, 2023
@dzbaker
IC: Caelum-rc4+dev64
ae31951 
*Combines:*

sch_lab v2.5.0-rc4+dev71
sample_app v1.3.0-rc4+dev65
to_lab v2.5.0-rc4+dev66
ci_lab v2.5.0-rc4+dev69
cFE v7.0.0-rc4+dev411
PSP v1.6.0-rc4+dev96

**Includes:**

*sch_lab*
- nasa/sch_lab#129
- nasa/sch_lab#149
- nasa/sch_lab#142
- nasa/sch_lab#134

*sample_app*
- nasa/sample_app#212
- nasa/sample_app#187
- nasa/sample_app#190

*to_lab*
- nasa/to_lab#168
- nasa/to_lab#134
- nasa/to_lab#146
- nasa/to_lab#148
- nasa/to_lab#152
- nasa/to_lab#158
- nasa/to_lab#163

*ci_lab*
- nasa/ci_lab#152
- nasa/ci_lab#153

*cFE*
- nasa/cFE#2462
- nasa/cFE#2408

*PSP*
- nasa/PSP#417

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Isaac Rowe <irowebbn@users.noreply.github.com>
Co-authored by: Jacob Hageman  <skliper@users.noreply.github.com>
@thnkslprpt thnkslprpt deleted the fix-128-standarize-naming branch November 14, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jphickey jphickey jphickey approved these changes

Assignees
No one assigned
Labels
CCB:Approved
Projects
None yet
Milestone
Fornax
Development

Successfully merging this pull request may close these issues.

Apply standard naming convention (SCH_LAB...)
3 participants
@thnkslprpt @jphickey @dzbaker