-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default/Example table assumes presence of other apps #152
Comments
jphickey
added a commit
to jphickey/to_lab
that referenced
this issue
Apr 12, 2023
Create an inclusion preprocessor macro for each app referred to in the subscription table, and only include that line if the app is present in the current configuration. In particular, do not assume that sample_app will always be there.
This was referenced Apr 12, 2023
dzbaker
added a commit
that referenced
this issue
Apr 13, 2023
Fix #152, adjust subscription table based on apps present
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this issue
Nov 13, 2023
*Combines:* sch_lab v2.5.0-rc4+dev71 sample_app v1.3.0-rc4+dev65 to_lab v2.5.0-rc4+dev66 ci_lab v2.5.0-rc4+dev69 cFE v7.0.0-rc4+dev411 PSP v1.6.0-rc4+dev96 **Includes:** *sch_lab* - nasa/sch_lab#129 - nasa/sch_lab#149 - nasa/sch_lab#142 - nasa/sch_lab#134 *sample_app* - nasa/sample_app#212 - nasa/sample_app#187 - nasa/sample_app#190 *to_lab* - nasa/to_lab#168 - nasa/to_lab#134 - nasa/to_lab#146 - nasa/to_lab#148 - nasa/to_lab#152 - nasa/to_lab#158 - nasa/to_lab#163 *ci_lab* - nasa/ci_lab#152 - nasa/ci_lab#153 *cFE* - nasa/cFE#2462 - nasa/cFE#2408 *PSP* - nasa/PSP#417 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Isaac Rowe <irowebbn@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this issue
Nov 14, 2023
*Combines:* sch_lab v2.5.0-rc4+dev71 sample_app v1.3.0-rc4+dev65 to_lab v2.5.0-rc4+dev66 ci_lab v2.5.0-rc4+dev69 cFE v7.0.0-rc4+dev411 PSP v1.6.0-rc4+dev96 **Includes:** *sch_lab* - nasa/sch_lab#129 - nasa/sch_lab#149 - nasa/sch_lab#142 - nasa/sch_lab#134 *sample_app* - nasa/sample_app#212 - nasa/sample_app#187 - nasa/sample_app#190 *to_lab* - nasa/to_lab#168 - nasa/to_lab#134 - nasa/to_lab#146 - nasa/to_lab#148 - nasa/to_lab#152 - nasa/to_lab#158 - nasa/to_lab#163 *ci_lab* - nasa/ci_lab#152 - nasa/ci_lab#153 *cFE* - nasa/cFE#2462 - nasa/cFE#2408 *PSP* - nasa/PSP#417 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Isaac Rowe <irowebbn@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The default value for the TO_LAB subscription table directly refers to
ci_lab
andsample_app
Msg IDs, assuming these apps will be present. This is fine for a user who is cloning the http://github.com/nasa/cFS bundle repo, because it includes these submodules. But in other cases if these other apps are not present, the table fails to build.This issue is now detected at configuration (CMake) time, if there is a reference to the include directories of a target that does not exist in this configuration.
To Reproduce
Notably, this change from compile to config time caused an unintended side effect- workflows for the other CFS apps seem to do this - it clones the CFS but modifies the
targets.cmake
configuration in such a way that it no longer includes thesample_app
.Expected behavior
Should not assume/require that
sample_app
will always be part of the config.Code snips
Problematic assumption is here in the table:
to_lab/fsw/tables/to_lab_sub.c
Line 52 in 41516d4
System observed on:
Github workflow (see https://github.com/nasa/LC/actions/runs/4681105860/jobs/8293280167)
Additional context
This assumption is also true for CI_LAB and SCH_LAB, but these lab apps are still included in the workflow runs, so it doesn't cause an error at this time. With the way that the CFS app workflow runs, it effectively replaces
sample_app
with the app under test, while leaving the rest of the default bundle config alone, hence why an assumption ofsample_app
being present is more of an issue than the others.Reporter Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: