Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't override the CC and C++ environment variables #1812

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ninotarantino
Copy link

Fixes an issue where some makefiles override the user's CC and C++ environment variables. This can stomp on compiler versions loaded via a package manager like spack or conan.

Closes #1811

Fixes an issue where some makefiles override the user's CC and C++
environment variables.
@ninotarantino ninotarantino linked an issue Dec 6, 2024 that may be closed by this pull request
@ninotarantino
Copy link
Author

@hchen99 This is ready for review.

@ninotarantino
Copy link
Author

I'm getting a really bizarre error when building some of the unit tests. Is it alright if we only modify the model directory makefiles and leave the test directory makefiles unchanged from master? This fix is really just to get Trick to build and I'm not too familiar with the test setup here. @hchen99

@hchen99
Copy link
Contributor

hchen99 commented Dec 11, 2024

I'm getting a really bizarre error when building some of the unit tests. Is it alright if we only modify the model directory makefiles and leave the test directory makefiles unchanged from master? This fix is really just to get Trick to build and I'm not too familiar with the test setup here. @hchen99

It's fine to just modify to get Trick to build.

@ninotarantino
Copy link
Author

Sounds good! I pushed an update. I ran the tests locally as well so we should be good now.

@hchen99
Copy link
Contributor

hchen99 commented Dec 12, 2024

I did checkout your updates and were able to build trick and run all the tests. It seems strange that it can't pass our CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't Override User's CC and CPP Environment Variables
2 participants