Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1811 dont override users cc and cpp env for data products #1819

Merged

Conversation

hchen99
Copy link
Contributor

@hchen99 hchen99 commented Dec 12, 2024

Testing PR for PR #1812

ninotarantino and others added 3 commits December 6, 2024 08:39
Fixes an issue where some makefiles override the user's CC and C++
environment variables.
@sharmeye
Copy link
Contributor

is this PR cursed? it looks cursed

@ninotarantino
Copy link
Contributor

Looks cursed to me. What if instead of changing the CC = cc lines to CC ?= cc we just change them to CC = gcc? Surely that'll work. We're only really hitting this error because the cc on our system doesn't link to the proper gcc, but running gcc directly will work.

I definitely thought this PR would be simpler lol.

@hchen99
Copy link
Contributor Author

hchen99 commented Dec 17, 2024

Yeah, unexpected. Do you still need to change CPP? Or you just need to change CC = cc to CC = gcc?

@coveralls
Copy link

coveralls commented Dec 17, 2024

Coverage Status

coverage: 55.924% (+0.009%) from 55.915%
when pulling 02130ce on 1811-dont-override-users-cc-and-cpp-env-for-data_products
into c6bdfed on master.

…order to show the necessary file changes for the PR.
@ninotarantino
Copy link
Contributor

Hey @hchen99, everything works now! This is good to be merged.

@hchen99
Copy link
Contributor Author

hchen99 commented Dec 18, 2024

@ninotarantino Great, thanks for confirming!

@sharmeye sharmeye merged commit 0695391 into master Jan 7, 2025
11 checks passed
@sharmeye sharmeye deleted the 1811-dont-override-users-cc-and-cpp-env-for-data_products branch January 7, 2025 16:43
@hchen99 hchen99 linked an issue Jan 9, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't Override User's CC and CPP Environment Variables
4 participants