-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1811 dont override users cc and cpp env for data products #1819
1811 dont override users cc and cpp env for data products #1819
Conversation
Fixes an issue where some makefiles override the user's CC and C++ environment variables.
is this PR cursed? it looks cursed |
Looks cursed to me. What if instead of changing the I definitely thought this PR would be simpler lol. |
Yeah, unexpected. Do you still need to change CPP? Or you just need to change CC = cc to CC = gcc? |
…order to show the necessary file changes for the PR.
Hey @hchen99, everything works now! This is good to be merged. |
@ninotarantino Great, thanks for confirming! |
Testing PR for PR #1812