Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urban Nature Access: support a proportion of urban nature instead of binary 1/0 #1180

Closed
4 tasks
phargogh opened this issue Feb 10, 2023 · 5 comments · Fixed by #1382 or #1383
Closed
4 tasks

Urban Nature Access: support a proportion of urban nature instead of binary 1/0 #1180

phargogh opened this issue Feb 10, 2023 · 5 comments · Fixed by #1382 or #1383
Assignees
Labels
science request A request/proposal from within natcap related to science (rather than engineering)
Milestone

Comments

@phargogh
Copy link
Member

@lmandle suggested that we modify the Urban Nature Access to support a proportion of urban nature in a pixel rather than a strict binary 1/0 classification.

It would be helpful to spec this out a bit more and be sure that we update all the needed places:

  • model source
  • MODEL_SPEC
  • sample data
  • user's guide
@lmandle
Copy link

lmandle commented Feb 11, 2023

It looks like Andreas tried to do this in his forked version of the UNA model (see slack thread here: https://stanford-natcap.slack.com/archives/C02FLK8C0A2/p1659740498859329) Do you have access to that, @phargogh ?

@phargogh
Copy link
Member Author

Yep! Andreas implemented the change in https://github.com/natcap/invest-mental-health, which is based off an older version of the Urban Nature Access model.

To make this ready for release, we would also need to implement tests, update the input descriptions, add sample data, and make sure the user's guide reflects the change. And with the meetings next week, I just don't think I'll have time to make it happen.

@lmandle
Copy link

lmandle commented Feb 11, 2023 via email

@phargogh phargogh added this to the 3.13.1 milestone Feb 20, 2023
@phargogh
Copy link
Member Author

@lmandle oh, for sure! I was mostly stating my rationale for my own memory on this ... I did remember that we had talked about this feature at some point and agreed that it would make sense to push off to a future release, and I forgot to include that important information in my post (and I'm sorry about that!)

@dcdenu4 dcdenu4 added the science request A request/proposal from within natcap related to science (rather than engineering) label Jun 8, 2023
phargogh added a commit to phargogh/invest that referenced this issue Aug 24, 2023
phargogh added a commit to phargogh/invest that referenced this issue Aug 24, 2023
phargogh added a commit to phargogh/invest that referenced this issue Aug 24, 2023
phargogh added a commit to phargogh/invest that referenced this issue Aug 24, 2023
phargogh added a commit to phargogh/invest that referenced this issue Aug 24, 2023
@phargogh
Copy link
Member Author

Because of #1354 proportions might not be represented in the sample data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
science request A request/proposal from within natcap related to science (rather than engineering)
Projects
None yet
3 participants