Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Urban Nature Access model #722

Closed
8 tasks done
phargogh opened this issue Nov 12, 2021 · 5 comments
Closed
8 tasks done

Implement Urban Nature Access model #722

phargogh opened this issue Nov 12, 2021 · 5 comments
Assignees
@phargogh
Labels
enhancement New feature or request in progress This issue is actively being worked on
Milestone
3.13.0

Comments

@phargogh
Copy link
Member

phargogh commented Nov 12, 2021 •
edited
Loading

This is a catch-all issue for implementing the Urban Nature Access model.

See https://github.com/natcap/softwareteam/issues/93 for details.

  • Add ARGS_SPEC
  • Implement validation
  • Add Qt interface based on ARGS_SPEC
  • Add sample data to the repository
  • Note model addition in HISTORY.rst
  • Add assertions to the whole-model test
  • Add a note to the User's Guide about when fractional populations may be a good idea and when they may not, but also that the model will not do any rounding on population inputs.
  • more individual tasks coming soon
@phargogh phargogh added the enhancement New feature or request label Nov 12, 2021
@phargogh phargogh self-assigned this Nov 12, 2021
phargogh added a commit to phargogh/invest that referenced this issue Nov 15, 2021
@phargogh
Adding some more boilerplate for the beginning of the model. RE:natca…
63a4298 
…p#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 15, 2021
@phargogh
Implementing population resampling.
e381c1f 
The function provided is a first stab at resampling/reprojecting a
population raster by way of converting to a population density, then
reprojecting and converting back to a population count.  Correctness has
yet to be determined, but this way we should pretty reasonably be
preserving the population counts. RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 15, 2021
@phargogh
Finishing basic test for resampling population.
4f3761d 
This adds the callthrough for the population raster resampling function
and also asserts that the outputs are reasonable for what we're trying
to do.  Initial results look like that at least in this basic test we're
getting numerically sensible results. RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 15, 2021
@phargogh
Testing multiple pixel sizes. RE:natcap#722
10c5f5a
phargogh added a commit to phargogh/invest that referenced this issue Nov 15, 2021
@phargogh
Adding a more interesting population warping test.
53c12bc 
This adds a seeded randomization step to the population warping test,
just so I can be more confident that this function is doing what I
expect it to do with more reasonable data.  It does, which I'm happy to
see.

RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 15, 2021
@phargogh
Docstring for the population resampling function.
e9a9754 
RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 15, 2021
@phargogh
Adding a test for the model.
b203b64 
This test doesn't have assertions yet, just the most basic inputs to
make sure the model can at least run.

RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 15, 2021
@phargogh
Adding the population resampling step to the graph.
fa86329 
RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 15, 2021
@phargogh
Adding some information to ARGS_SPEC. RE:natcap#722
9b6726c
@phargogh phargogh mentioned this issue Nov 15, 2021
Merged
phargogh added a commit to phargogh/invest that referenced this issue Nov 15, 2021
@phargogh
Removing old notes-to-self. RE:natcap#722
afe38f6
phargogh added a commit to phargogh/invest that referenced this issue Nov 15, 2021
@phargogh
Adding required fields entry to the ARGS_SPEC. RE:natcap#722
451a482
phargogh added a commit to phargogh/invest that referenced this issue Nov 17, 2021
@phargogh
Updating import order. RE:natcap#722
14fe6e2
phargogh added a commit to phargogh/invest that referenced this issue Nov 17, 2021
@phargogh
Using isort to sort imports and adding configuration for it. RE:natca…
442e84e 
…p#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 17, 2021
@phargogh
Adding keys with spatial overlap, as they are known.
a1cea27 
RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 17, 2021
@phargogh
Adding meters projection information to LULC and population rasters. RE:
32834c4 
natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 17, 2021
@phargogh
Adding lienar projection in m requirement to execute docstring. RE:na…
9ae6214 
…tcap#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 17, 2021
@phargogh
Renaming function parameters to reflect the intended source. RE:natca…
6fa201f 
…p#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 17, 2021
@phargogh
Minor typo. RE:natcap#722
ae68329
phargogh added a commit to phargogh/invest that referenced this issue Nov 17, 2021
@phargogh @dcdenu4
Update typo in pyproject.toml
fc134d2 
RE:natcap#722

Co-authored-by: Doug <dcdenu4@gmail.com>
phargogh added a commit to phargogh/invest that referenced this issue Nov 18, 2021
@phargogh
Squaring off the LULC's pixels.
e8f3edb 
Since I'm now aligning two rasters in a way that's more manual than
simply calling `pygeoprocessing.align_and_resize_raster_stack`, I've
added a few assertions to help me be confident that this is working as I
expect it to. RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 18, 2021
@phargogh
Replacing assertTrue with assertIn where sensible.
46ab29f 
AssertIn has a much more sensible default error message which helps to
eliminate a debugging step on a failure: you can see the object printed
right there in the pytest output instead of needing to enter PDB to see
it.  RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 18, 2021
@phargogh
Starting an ARGS_SPEC for the decay function.
a9910cf 
The decay function parameter is described as a non-user-facing parameter
that may need to be experimented with by the science teams.  I interpret
this as that it should therefore be exposed until further notice.
RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 18, 2021
@phargogh
Adding the SG:PB gaussian kernel function to utils.
fe604bc 
This also adds a test for it, which didn't exist before.

Minor modifications for filennames and cache flushing have been added to
the utils function from the SG version. RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 18, 2021
@phargogh
Replacing SG gaussian kernel with utils.
b5c1f6c 
RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 18, 2021
@phargogh
Replacing GLOBIO gaussian kernel with utils.
d91c135 
RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 18, 2021
@phargogh
Adding a function for instantaneous decay.
b0e9c21 
This function is based on the stormwater implementation of the search
kernel.

RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Nov 18, 2021
@phargogh
Reworking the instantaneous decay function.
162cf01 
The instantaneous decay function is now a blockwise function to avoid
the case where we have a large search radius and small pixels.  RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Jan 31, 2023
@phargogh
Being a little more careful about what needs a task join(). RE:natcap…
75a94c4 
…#722
phargogh added a commit to phargogh/invest that referenced this issue Jan 31, 2023
@phargogh
Using utils.array_equals_nodata() instead of isclose() for consistenc…
9a27ea3 
…y and brevity. RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Jan 31, 2023
@phargogh
Fixing block reading in a simple iterblocks call. RE:natcap#722
cc68dd1
phargogh added a commit to phargogh/invest that referenced this issue Jan 31, 2023
@phargogh
Fixing some critical issues in weighted sum. RE:natcap#722
f7abc41
phargogh added a commit to phargogh/invest that referenced this issue Jan 31, 2023
@phargogh
Finishing a comment. RE:natcap#722
f0d78a5
phargogh added a commit to phargogh/invest that referenced this issue Jan 31, 2023
@phargogh
Forcing cleanup of a few gdal objects. RE:natcap#722
868213d
phargogh added a commit to phargogh/invest that referenced this issue Feb 3, 2023
@phargogh
Adding a test for the power kernel and removing unused import.
c91eaa6 
RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Feb 3, 2023
@phargogh
Adding a test for exponential decay.
238b070 
Also fixes a bug revealed by the test. RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Feb 3, 2023
@phargogh
Adding a test for the gaussian kernel.
84f9d47 
RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Feb 3, 2023
@phargogh
Bumping the UG repo rev for the draft UNA chapter.
98eae1c 
RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Feb 7, 2023
@phargogh
Renaming greenspace_budget to greenspace_balance.
a9f34bf 
Per request by Yingjie.

RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Feb 7, 2023
@phargogh
Correcting names, bumping UG, moving a file to outputs.
4ca9940 
RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Feb 8, 2023
@phargogh
Commenting out power function stuff.
518445a 
@dcdenu4 and I decided that because the power function is incompletely
specified in the design document and it'll take a little work to
implement properly, and also because the core model parts are working
even without the power kernel.  The power kernel can, if needed, be
added in to the model later on, like in a bugfix release.

RE:natcap#722
This was referenced Feb 8, 2023
Open
Open
@phargogh
Copy link
Member Author

phargogh commented Feb 20, 2023 •
edited
Loading

We have a PR over on bitbucket (https://bitbucket.org/natcap/invest-sample-data/pull-requests/29) that includes the sample data. Once that's approved and merged, we need to be sure to include it in the updated release.

  • include the updated UNA sample data in the release.

phargogh added a commit to phargogh/invest that referenced this issue Feb 20, 2023
@phargogh
Adding sample data to the Makefile.
f3a1afa 
RE:natcap#722
@phargogh phargogh mentioned this issue Feb 20, 2023
Merged
phargogh added a commit to phargogh/invest that referenced this issue Feb 21, 2023
@phargogh
Bumping the sample data repo rev for the merged data.
2ed3142 
RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Feb 21, 2023
@phargogh
Removing globio to match recent deprecation.
4657e28 
RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Feb 27, 2023
@phargogh
Bumping the UG repo rev for the globio removal.
63387c3 
RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Mar 10, 2023
@phargogh
Noting new model in HISTORY.
a18b3fe 
RE:natcap#722
@phargogh phargogh mentioned this issue Mar 10, 2023
Merged
phargogh added a commit to phargogh/invest that referenced this issue Mar 15, 2023
@phargogh
Adding UNA MODEL_SPEC for outputs.
a44693b 
RE:natcap#722
phargogh added a commit to phargogh/invest that referenced this issue Mar 15, 2023
@phargogh
Correcting ARGS_SPEC --> MODEL_SPEC. RE:natcap#722
2d14019
phargogh added a commit to phargogh/invest that referenced this issue Mar 15, 2023
@phargogh
Correcting a band type. RE:natcap#722
a591151
@phargogh phargogh mentioned this issue Mar 15, 2023
Merged
3 tasks
phargogh added a commit to phargogh/invest that referenced this issue Mar 15, 2023
@phargogh
Removing deprecated ui file for UNA. RE:natcap#722.
a7e33dd
@phargogh
Copy link
Member Author

UNA has been merged. Although other issues exist, they are separate from the initial model release.

#1175 #1176 #1180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
enhancement New feature or request in progress This issue is actively being worked on
Projects
None yet
Milestone
3.13.0
Development

No branches or pull requests
2 participants
@dcdenu4 @phargogh