Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CV does not handle nan in bathymetry #1528

Closed
davemfish opened this issue Feb 20, 2024 · 0 comments · Fixed by #1530
Closed

CV does not handle nan in bathymetry #1528

davemfish opened this issue Feb 20, 2024 · 0 comments · Fixed by #1530
Assignees
@davemfish
Labels
bug Something isn't working
Milestone
3.14.2

Comments

@davemfish
Copy link
Contributor

A raster with nan as nodata will yield nan values from extract_bathymetry_along_ray if any of the fetch ray overlaps nodata.

This looks like a case where we're using math.isclose where we should be using numpy.isclose(x, y, equal_nan=True).
@davemfish davemfish self-assigned this Feb 20, 2024
@davemfish davemfish added the bug Something isn't working label Feb 20, 2024
@davemfish davemfish added this to the 3.14.2 milestone Feb 20, 2024
davemfish added a commit to davemfish/invest that referenced this issue Feb 20, 2024
@davemfish
add tests to cover nan nodata in bathymetry. natcap#1528
69fabb1
davemfish added a commit to davemfish/invest that referenced this issue Feb 20, 2024
@davemfish
use numpy.isclose and check for equal nan. natcap#1528
a14f719
davemfish added a commit to davemfish/invest that referenced this issue Feb 21, 2024
@davemfish
note for history. natcap#1528
086aade
davemfish added a commit to davemfish/invest that referenced this issue Feb 21, 2024
@davemfish
fix indent. natcap#1528
beca6d7
@davemfish davemfish mentioned this issue Feb 21, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davemfish davemfish

Labels
bug Something isn't working
Projects
None yet
Milestone
3.14.2
Development

Successfully merging a pull request may close this issue.

Bugfix CV: mask out nan nodata davemfish/invest
1 participant
@davemfish