Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix CV: mask out nan nodata #1530

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

davemfish
Copy link
Contributor

@davemfish davemfish commented Feb 20, 2024

We were not properly masking out nan values from the bathymetry raster.

I updated an isclose check and updated a test to confirm that nan values can be properly masked like any other nodata value. Other raster ops in this model were already doing the proper checks via pygeoprocessing.array_equals_nodata.

Fixes #1528

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

@davemfish davemfish changed the title Bugfix/cv 1528 nan nodata Bugfix CV: mask out nan nodata Feb 21, 2024
@davemfish davemfish marked this pull request as ready for review February 21, 2024 14:57
@davemfish davemfish requested a review from phargogh February 28, 2024 19:47
Copy link
Member

@phargogh phargogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks @davemfish !

@phargogh phargogh merged commit 330b9c7 into natcap:main Feb 29, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CV does not handle nan in bathymetry
2 participants