Add ESLint and Prettier configuration #14
Conversation
| @@ -26,5 +28,8 @@ | |||
| "devDependencies": { | |||
| "@lerna/clean": "^5.5.2", | |||
| "lerna": "^5.5.2" | |||
| }, | |||
| "resolutions": { | |||
| "typescript": "~4.7" | |||
There was a problem hiding this comment.
I needed to fix the typescript version due to a bug on parcel
parcel-bundler/parcel#8419
lucaslencinas
changed the title
.github/workflows/main.yml
Outdated
| cmd: lint:test # will run `yarn lint:test` command | ||
| - uses: borales/actions-yarn@v3.0.0 | ||
| with: | ||
| cmd: prettier:check # will run `yarn prettier:check` command |
There was a problem hiding this comment.
I haven't checked this much. I want to run this command while building a PR and also when merging to main
There was a problem hiding this comment.
wait why do we need both? can't we just use lint:test or prettier:check? if we need both I'd suggest we wrap it in our package json
| * Being respectful of differing opinions, viewpoints, and experiences | ||
| * Giving and gracefully accepting constructive feedback | ||
| * Accepting responsibility and apologizing to those affected by our mistakes, | ||
| - Demonstrating empathy and kindness toward other people |
There was a problem hiding this comment.
just a question: was this because of the linter too or is it unrelated?
There was a problem hiding this comment.
Yes, because of the linter. Looks the same on github preview mode so I accepted those rules on the linter. If we find problems later, we can adapt and tweak it a bit.
README.md
Outdated
| @@ -12,20 +12,27 @@ For now, there are very few commands and will change soon. | |||
| yarn install ## or npm install | |||
| ``` | |||
|
|
|||
| - Build the SDK library | |||
| - Build the SDK library and the React frontend | |||
There was a problem hiding this comment.
I'd suggest
and the React sample frontend
So that we are crystal clear that the main component is the SDK
|
LGTM, I left a few minor comments but when you fix the conflicts I can approve |
lucaslencinas
force-pushed
the
add-eslint
branch
from
f555db4 to
ffe04c3
Compare
Adding some basic configuration for having ESLint.
Nothing too fancy, just basic configuration
Also, adding configuration for Prettier.
More info on their page https://prettier.io/docs/en/index.html
Make sure you set up Prettier on your editor so you can have it executed everytime you save a file automatically and modifying