Auto-Login to CKAN (but only if the user belongs to ckan-admin group in Keycloak) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iperezx
reviewed
Dec 19, 2023
| server_url = tk.config.get('ckanext.keycloak.server_url', environ.get('CKANEXT__KEYCLOAK__SERVER_URL')) | ||
| client_id = tk.config.get('ckanext.keycloak.client_id', environ.get('CKANEXT__KEYCLOAK__CLIENT_ID')) | ||
| realm_name = tk.config.get('ckanext.keycloak.realm_name', environ.get('CKANEXT__KEYCLOAK__REALM_NAME')) | ||
| redirect_uri = tk.config.get('ckanext.keycloak.redirect_uri', environ.get('CKANEXT__KEYCLOAK__REDIRECT_URI')) | ||
| client_secret_key = tk.config.get('ckanext.keycloak.client_secret_key', environ.get('CKANEXT__KEYCLOAK__CLIENT_SECRET_KEY')) | ||
| client_secret_key = tk.config.get('ckanext.keycloak.client_secret_key', | ||
| environ.get('CKANEXT__KEYCLOAK__CLIENT_SECRET_KEY')) |
There was a problem hiding this comment.
Is it not picking up the values from the .ini file?
There was a problem hiding this comment.
Hm, I'm not sure, may be it does
iperezx
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three main test/use cases:
CKAN Admin
a. User goes to the front-end and logs in as CKAN authorized user
b. User clicks Catalog
Result: User will be logged into the CKAN. (not as system admin, but as a user that can create new org, dataset etc)
CKAN non-admin
a. User goes to the front-end and logs in as NOT CKAN authorized user
b. User clicks Catalog
Result: User will not be logged into the CKAN
Not logged in
a. User goes to the front-end (without login)
b. User clicks Catalog
Result: User will not be logged into the CKAN