[FIXED] Make sure to not forward a message across a route for routed dq subs #4578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are a spoke leaf node. Mimi same behavior for normal subs. Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mimic same behavior for normal subs.
Note that when a queue subscription is behind both a spoke leafnode connection and a service import the message will be delivered over the leafnode since service imports are binary signals that are just on. Need a more thorough investigation for a proper fix. For now its best to not have the service import on the spoke leafnode such that the raw queue sub's information if relayed across the leafnode.
Signed-off-by: Derek Collison derek@nats.io
Resolves #4367