Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Do not bypass authorization blocks when turning on $SYS account access #4605

Merged
merged 1 commit into from
Sep 28, 2023
Merged

[FIXED] Do not bypass authorization blocks when turning on $SYS account access #4605

merged 1 commit into from
Sep 28, 2023

Conversation

derekcollison
Copy link
Member

Only setup auto no-auth for $G account iff no authorization block was defined.

Signed-off-by: Derek Collison derek@nats.io

Resolves #4535

@derekcollison
Only setup auto no-auth for $G account iff no authorization block was…
2737c56 
… defined.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner September 28, 2023 21:03
neilalexander
neilalexander approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit fa5b7af into main Sep 28, 2023
2 checks passed
@derekcollison derekcollison deleted the dis-4535 branch September 28, 2023 21:17
@wallyqs wallyqs mentioned this pull request Oct 11, 2023
Merged
wallyqs added a commit that referenced this pull request Oct 11, 2023
@wallyqs
Backports from v2.10 for v2.9.23 release (#4647)
8b981a2 
Backports the following PRs from v2.10:

- #4510 
- #4556 
- #4578 
- #4605 

Signed-off-by: Your Name <wally@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekcollison @neilalexander