Fix workqueue streams consumers receiving messages that were dropped by stream on limits #5059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Waldemar Quevedo <wally@nats.io>
derekcollison
force-pushed
the
workqueue-consumer-discard-new
branch
from
4a648f3 to
f7b3e40
Compare
…ax bytes set, we need to do those checks before proposing the message. The reason is that the consumer ack flow will be async state and some replicas might accept the message where others would not based on limits. Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
workqueue-consumer-discard-new
branch
from
f7b3e40 to
9a496ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.