-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry picks for Release v2.10.11 #5074
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wallyqs
commented
Feb 13, 2024
•
edited
Loading
edited
- Use IO gate when doing io.FullRead on block #5045
- [FIX] [authcallout] ensure authcallout in operator mode sends an auth error instead of timeout #5038
- test: update certs for TestTLSClientCertificateCNBasedAuth #5035
- [ADDED] MQTT: test/bench using external client #4821
- [ADDED] JetStream domain elected advisory for when we have a new meta leader. #5041
- FIXED: MQTT retained message consumer creation #5048
- [FIXED] KeyValue not found after server restarts #5054
- Fix potential skew in stream and consumers when applying account quota limits #5056
- Fix workqueue streams consumers receiving messages that were dropped by stream on limits #5059
- Support building for linux/ppc64le arch #5058
- [FIXED] Update dependencies. #5068
- [IMPROVED] Use GOMEMLIMIT if set to calculate dynamic memory limits for JetStream #5073
- [FIXED] Make sure to properly handle filtered purges with consumers that have a wider filtered subject. #5075
- Bump Go version to v1.21.7 #5076
- [FIXED] flapping TestMQTTDecodeRetainedMessage #5077
Signed-off-by: Waldemar Quevedo <wally@nats.io>
…th violation error was not sent to the client, thus the client would simply timeout.
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
…a-leader. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
- Cleaned up the retained message consumer name so that it does not cause problems - Per @derekcollison's recommendation, use an ephemeral consumer for retained messages
Do not force sequence mismatches and possible dataloss on first sequence move past a catchup request. When a server restarts and does a stream catchup where the snapshot from the leader is for messages it no longer has, we would create a sequence mismatch reset on the follower. Also on a catchup if the stream state has moved past the updated request range from a follower, meaning first for the new state is past the last of the request, extend and continue catchup. Signed-off-by: Derek Collison <derek@nats.io> --------- Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
…tered mode. If not clustered only check in processJetStreamMsg. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
…ax bytes set, we need to do those checks before proposing the message. The reason is that the consumer ack flow will be async state and some replicas might accept the message where others would not based on limits. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
This request was raised in #555 (2017) and more recently in the nats-docker repo here: nats-io/nats-docker#117. Signed-off-by: Byron Ruth <byron@nats.io>
…ynamic memory calculations for JetStream. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…der filtered subject. Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.