Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic on /raftz when shutting down #5672

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix panic on /raftz when shutting down #5672

merged 1 commit into from
Jul 22, 2024

Conversation

neilalexander
Copy link
Member

Signed-off-by: Neil Twigg neil@nats.io

@neilalexander neilalexander requested a review from a team as a code owner July 18, 2024 13:20
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one nit

@@ -3788,7 +3788,13 @@ func (s *Server) HandleRaftz(w http.ResponseWriter, r *http.Request) {
gfilter := r.URL.Query().Get("group")
afilter := r.URL.Query().Get("acc")
if afilter == "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EMPTY

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Signed-off-by: Neil Twigg <neil@nats.io>
@derekcollison derekcollison merged commit 3305fc5 into main Jul 22, 2024
2 of 4 checks passed
@derekcollison derekcollison deleted the neil/raftz2 branch July 22, 2024 15:40
bruth added a commit that referenced this pull request Jul 30, 2024
Includes the following:

* #5602
* #5672
* #5668
* #5607
* #5687
* #5695
* #5697
* #5704
* #5706
* #5709
* #5710
* #5713
* #5719

Some PRs specifically excluded:

* #5707 — based on a 2.11 NRG
PR
* #5690 — continue to allow
Go 1.20 for 2.10.x
* Various other NRG PRs which are higher risk and destined for 2.11
instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants