Cherry-picks for 2.10.19-RC.2 #5718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an alternate approach to the PR #5484 from @wjordan. Using the code in that PR with the test added in this PR, I could still see duplicate routes (up to 125 in one of the matrix), and still had a data race (that could have easily be fixed). The main issue is that the increment happens in connectToRoute, which is running from a go routine, so there were still chances for duplicates. Instead, I took the approach that those duplicates were the result of way too many gossip protocols. Suppose that you have servers A and B already connected. C connects to A. A gossips to B that it should connect to C. When that happened, B would gossip to A the server C and C would gossip to A the server B, which all that was unnecessary. It would grow quite fast with the size of the cluster (that is, several thousands for a cluster size of 15 or so). Resolves #5483 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
If we failed to start the Raft group subscriptions then we were calling `shutdown` with the `shouldDelete` flag set, which would nuke the state on disk, blowing away the WAL, the term and vote etc. However, this could happen if a Raft group tried to be started while the server was shutting down. When this happened, we would see a log entry saying `Error creating raft group: system account not setup` and then the Raft state would get deleted, so after a restart, all state was lost. This PR changes `shouldDelete` to false so that we preserve the state on disk for the next startup. Signed-off-by: Neil Twigg <neil@nats.io>
While validating the ideas in ADR-44 the proposed improvements caught the fact that a snapshot request was being sent to a restore API call. Tests passed because there was enough overlap in the structs but strictly should have been a failure due to the invalid request Signed-off-by: R.I.Pienaar <rip@devco.net>
…tion` Signed-off-by: Neil Twigg <neil@nats.io>
…atch filters (#5699) Signed-off-by: Derek Collison <derek@nats.io> Signed-off-by: Derek Collison <derek@nats.io>
The stream state and replica info is only guaranteed to be accurate when returned by the leader of a given stream. This new option returns stream details only for the stream in which the server is the leader for that stream. For systems with many streams this can significantly reduce the amount of data returned when scraping across all servers since non-leader details will likely be ignored. Fix #5698 Signed-off-by: Byron Ruth <byron@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
We had a use case with millions of subjects and the last sequence checked being in the next to the last block. The consumer had a wildcard that matched lots of entries that were behind where we were. This would burn alot of cpu and when a stream had lots of consumers and they shift leadership this would introduce some instability due to all the cpu cycles. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
…sive compact attempts. Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following:
/raftzwhen shutting down #5672WorkQueuePolicyretention issue #5697TestNRGUnsuccessfulVoteRequestDoesntResetElectionTimer#5706getAccAndResultFromCache#5713Some PRs specifically excluded:
TestNRGSwitchStateClearsQueues#5707 — based on a 2.11 NRG PR