Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject leafnode cluster names with spaces #5732

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Reject leafnode cluster names with spaces #5732

merged 2 commits into from
Aug 6, 2024

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Aug 1, 2024

This is a relaxed version of v2.11s change (https://github.com/nats-io/nats-server/pull/5676/files) which still allows cluster names with spaces in gateways and clusters.

@wallyqs wallyqs requested a review from a team as a code owner August 1, 2024 05:40
@ripienaar

This comment was marked as resolved.

Sign in to view
@wallyqs wallyqs force-pushed the backport/v2.10.19 branch from 800c7ab to 2248f4a Compare August 1, 2024 06:11
wallyqs
wallyqs commented Aug 1, 2024
View reviewed changes
@wallyqs wallyqs force-pushed the backport/v2.10.19 branch from 2248f4a to 8d86668 Compare August 1, 2024 06:17
ripienaar
ripienaar reviewed Aug 1, 2024
View reviewed changes
@wallyqs wallyqs force-pushed the backport/v2.10.19 branch 2 times, most recently from ec57f2d to 05a1131 Compare August 1, 2024 07:31
neilalexander
neilalexander reviewed Aug 1, 2024
View reviewed changes
@wallyqs wallyqs force-pushed the backport/v2.10.19 branch from 05a1131 to 66ebb63 Compare August 1, 2024 10:41
mprimi
mprimi reviewed Aug 1, 2024
View reviewed changes
@wallyqs wallyqs force-pushed the backport/v2.10.19 branch from 66ebb63 to 3833649 Compare August 1, 2024 20:41
@derekcollison
Copy link
Member

This ready for review? @bruth you and @kozlovic ok with approach here?

kozlovic
kozlovic requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do it also in processing the LEAF info or not?

@wallyqs wallyqs force-pushed the backport/v2.10.19 branch from c841c00 to 3935fc6 Compare August 6, 2024 13:17
kozlovic
kozlovic approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wallyqs added 2 commits August 6, 2024 06:42
@wallyqs
Reject leafnode cluster names with spaces
8f84b44 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs
Add warning message that server name affects cluster name and leafs
5177f3a 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs wallyqs force-pushed the backport/v2.10.19 branch from 3935fc6 to 5177f3a Compare August 6, 2024 13:43
@wallyqs wallyqs changed the base branch from release/v2.10.19 to neil/21019rc3 August 6, 2024 13:43
neilalexander
neilalexander approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 0c6517e into neil/21019rc3 Aug 6, 2024
5 checks passed
@neilalexander neilalexander deleted the backport/v2.10.19 branch August 6, 2024 14:42
@neilalexander neilalexander mentioned this pull request Aug 6, 2024
Merged
neilalexander added a commit that referenced this pull request Aug 6, 2024
@neilalexander
Cherry-picks for 2.10.19-RC.3 (#5745)
23f030e 
Includes the following:

- #5690
- #5725
- #5729
- #5734
- #5735
- #5736
- #5743
- #5744
- #5751
- #5755
- #5754
- #5732
- #5750
- #5756

The following were reverted before this PR:
- #5602

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripienaar ripienaar ripienaar left review comments

@mprimi mprimi mprimi left review comments

@neilalexander neilalexander neilalexander approved these changes

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wallyqs @ripienaar @derekcollison @neilalexander @mprimi @kozlovic