Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise sublist matching for gateways, client replies #5736

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Optimise sublist matching for gateways, client replies #5736

merged 1 commit into from
Aug 1, 2024

Conversation

neilalexander
Copy link
Member

This should reduce the number of string allocations on some gateway hot paths quite considerably.

Note that MatchBytes() passes in a new option to the internal match() function to ensure a copy is taken when writing to the cache to ensure we don't create race conditions from memory reuse. This doesn't affect Match() so the behaviour there is unchanged.

Signed-off-by: Neil Twigg neil@nats.io

@neilalexander
Optimise sublist matching for gateways, client replies
bb45ca6 
Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner August 1, 2024 16:44
derekcollison
derekcollison approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 92a8579 into main Aug 1, 2024
5 checks passed
@derekcollison derekcollison deleted the neil/gatewayinterest branch August 1, 2024 17:25
@neilalexander neilalexander mentioned this pull request Aug 2, 2024
Merged
neilalexander added a commit that referenced this pull request Aug 6, 2024
@neilalexander
Cherry-picks for 2.10.19-RC.3 (#5745)
23f030e 
Includes the following:

- #5690
- #5725
- #5729
- #5734
- #5735
- #5736
- #5743
- #5744
- #5751
- #5755
- #5754
- #5732
- #5750
- #5756

The following were reverted before this PR:
- #5602

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilalexander @derekcollison