[IMPROVED] When we detect a bump in clfs try to snapshot (if prior was zero force). #5806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
clfs-snap
branch
from
08601fe to
23b6936
Compare
MauriceVanVeen
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
LGTM
Probably want to target main so #5794 is not reverted as part of kv-sync-issue-simple-reproduce branch (revert was just for making the repro easier).
derekcollison
changed the base branch from
kv-sync-issue-simple-reproduce
to
main
|
Done - #5812 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Collison derek@nats.io