Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data race in TestNRGTermDoesntRollBackToPtermOnCatchup #5991

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix data race in TestNRGTermDoesntRollBackToPtermOnCatchup #5991

merged 1 commit into from
Oct 11, 2024

Conversation

neilalexander
Copy link
Member

Signed-off-by: Neil Twigg neil@nats.io

@neilalexander neilalexander requested a review from a team as a code owner October 11, 2024 13:09
@neilalexander
Fix data race in TestNRGTermDoesntRollBackToPtermOnCatchup
3586b05 
Signed-off-by: Neil Twigg <neil@nats.io>
derekcollison
derekcollison approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit c94b5f9 into main Oct 11, 2024
5 checks passed
@derekcollison derekcollison deleted the neil/nrgfixrace branch October 11, 2024 16:52
@neilalexander neilalexander mentioned this pull request Nov 25, 2024
Merged
neilalexander added a commit that referenced this pull request Nov 25, 2024
@neilalexander
Cherry-picks for 2.10.23-RC.5 (#6171)
24acb45 
Includes the following:

- #5661
- #5666
- #5671
- #5344
- #5684
- #5689
- #5691
- #5714
- #5717
- #5707
- #5792
- #5912
- #5957
- #5700
- #5975
- #5991
- #5987
- #6027
- #6038
- #6053
- #5848
- #6055
- #6056
- #6060
- #6061
- #6072
- #5832
- #6073
- #6107

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilalexander @derekcollison