NRG: Don't switch to candidate when waiting for pending applies #6056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauriceVanVeen
changed the title
MauriceVanVeen
force-pushed
the
maurice/dont-become-candidate-during-process-stream-snapshot
branch
from
474a4b5 to
943d20d
Compare
MauriceVanVeen
changed the title
MauriceVanVeen
commented
Oct 30, 2024
MauriceVanVeen
force-pushed
the
maurice/dont-become-candidate-during-process-stream-snapshot
branch
from
943d20d to
3bc1227
Compare
MauriceVanVeen
force-pushed
the
maurice/dont-become-candidate-during-process-stream-snapshot
branch
from
3bc1227 to
61c6c59
Compare
|
Let me know when ready for review. |
|
Maurice and I have been on Zoom talking about this change and we've come up with a cleaner fix, so will be posting an update soon. Will let you know when ready for review. |
MauriceVanVeen
force-pushed
the
maurice/dont-become-candidate-during-process-stream-snapshot
branch
from
61c6c59 to
c3e65f2
Compare
MauriceVanVeen
changed the title
MauriceVanVeen
force-pushed
the
maurice/dont-become-candidate-during-process-stream-snapshot
branch
2 times, most recently
from
3eb4281 to
be280f0
Compare
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/dont-become-candidate-during-process-stream-snapshot
branch
from
be280f0 to
7af96d8
Compare
MauriceVanVeen
changed the title
|
@derekcollison This one is ready for review now! |
| if n.observer || n.paused { | ||
| // Avoid petitioning to become leader if we're behind on applies. | ||
| if n.observer || n.paused || n.applied < n.commit { | ||
| n.resetElect(minElectionTimeout / 4) |
There was a problem hiding this comment.
Don't want to slow down the potential for an election too much, so this ends up being 1 second in normal operation instead of 4 to 9 seconds. Divide because then it speeds up in the unit tests along with all the other consts.
derekcollison
deleted the
maurice/dont-become-candidate-during-process-stream-snapshot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follower could become candidate/leader before processing a snapshot. Based on timing the snapshot could enter into the apply queue, and before
n.PauseApply()is called the follower could freely become leader and then fail processing the snapshot.When a snapshot is not successfully applied yet, block the follower from becoming candidate until the snapshot is processed.
Signed-off-by: Maurice van Veen github@mauricevanveen.com