NRG: Use configured sync intervals for group stores #6041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
force-pushed
the
neil/nrgsyncinterval
branch
2 times, most recently
from
4f9abd8 to
a846d00
Compare
Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/nrgsyncinterval
branch
from
a846d00 to
9be497f
Compare
Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/nrgsyncinterval
branch
from
9be497f to
886e9ee
Compare
neilalexander
added a commit
that referenced
this pull request
Nov 12, 2024
Includes the following: * Some tweaks to the NRG test helpers * #6055 * #6061 * #6065 * #6041 (but with `math/rand` instead of `math/rand/v2` due to an older Go version in CI for 2.10.x) * #6066 * #6067 * #6069 * #6075 * #6082 * #6087 * #6086 * #6088 * #6089 * #6092 * #6096 * #6098 * #6097 * #6105 * #6104 * #6106 * #6109 * #6111 * #6112 Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
added a commit
that referenced
this pull request
Nov 14, 2024
Previously this was always firing at the exact interval. Then #6041 changed this so that the first firing was anytime between 1s and the interval to spread out different stores. This tweaks it once more to anytime between interval/2 and interval. It will still spread things out a bit but hit the benchmarks a bit less badly. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
added a commit
that referenced
this pull request
Nov 14, 2024
Previously this was always firing at the exact interval. Then #6041 changed this so that the first firing was anytime between 1s and the interval to spread out different stores. This tweaks it once more to anytime between interval/2 and interval. It will still spread things out a bit but hit the benchmarks a bit less badly. Also go back to `math/rand` instead of `math/rand/v2` due to availability in Go versions that we still care about for 2.10.x. Signed-off-by: Neil Twigg <neil@nats.io>
derekcollison
added a commit
that referenced
this pull request
Nov 14, 2024
Previously this was always firing at the exact interval. Then #6041 changed this so that the first firing was anytime between 1s and the interval to spread out different stores. This tweaks it once more to anytime between interval/2 and interval. It will still spread things out a bit but hit the benchmarks a bit less badly. Also go back to `math/rand` instead of `math/rand/v2` due to availability in Go versions that we still care about for 2.10.x. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
added a commit
that referenced
this pull request
Nov 14, 2024
Previously this was always firing at the exact interval. Then #6041 changed this so that the first firing was anytime between 1s and the interval to spread out different stores. This tweaks it once more to anytime between interval/2 and interval. It will still spread things out a bit but hit the benchmarks a bit less badly. Also go back to `math/rand` instead of `math/rand/v2` due to availability in Go versions that we still care about for 2.10.x. Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neil Twigg neil@nats.io