Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'accountName > streamName' logs consistent #6065

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

MauriceVanVeen
Copy link
Member

When logging about streams or consumers, the order is always accountName > streamName > consumerName. For example:

s.Noticef("JetStream cluster new consumer leader for '%s > %s > %s'", ca.Client.serviceAccount(), streamName, consumerName)

This was not fully consistent everywhere, so updated the cases where it was flipped. (streamName > accountName)

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Verified

This commit was signed with the committer’s verified signature.
MauriceVanVeen Maurice van Veen
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner October 31, 2024 21:13
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit d4decde into main Nov 1, 2024
5 checks passed
@derekcollison derekcollison deleted the maurice/consistent-acc-stream-logs branch November 1, 2024 02:13
neilalexander added a commit that referenced this pull request Nov 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Includes the following:

* Some tweaks to the NRG test helpers
* #6055
* #6061
* #6065 
* #6041 (but with `math/rand`
instead of `math/rand/v2` due to an older Go version in CI for 2.10.x)
* #6066
* #6067
* #6069
* #6075
* #6082
* #6087
* #6086
* #6088
* #6089
* #6092
* #6096
* #6098
* #6097
* #6105
* #6104
* #6106
* #6109
* #6111
* #6112

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants