[FIXED] only UpdateDelivered with quorum when clustered
#6139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
changed the title
UpdateDelivered with quorum when clusteredUpdateDelivered with quorum when clustered
|
For what it's worth I think this type of change makes sense. Quorum is what aligns the leader with the followers. If we're making persistent changes to the state of an asset without going through the Raft apply queue, then we've undermined the point of running Raft in the first place and then all bets are completely off when the leader changes. |
|
Like I said better to discuss on a call / video. |
|
@derekcollison , I've marked this PR ready for review as well. We've discussed that only the |
MauriceVanVeen
pushed a commit
that referenced
this pull request
Nov 21, 2024
`store.UpdateDelivered` would always be called, without checking quorum. Which meant that we could get a consumer to be ahead on delivered after switching leader. This change makes `o.updateDelivered` consistent with `o.updateAcks`, which does the same; if clustered propose through RAFT, if not just update delivered directly. Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store.UpdateDeliveredwould always be called, without checking quorum. Which meant that we could get a consumer to be ahead on delivered after switching leader. This change makeso.updateDeliveredconsistent witho.updateAcks, which does the same; if clustered propose through RAFT, if not just update delivered directly.Signed-off-by: Maurice van Veen github@mauricevanveen.com