[FIXED] o.chkflr must not be greater than o.asflr+1 #6146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauriceVanVeen
force-pushed
the
maurice/fix-chkfloor
branch
from
198eb42 to
ebe3dbc
Compare
MauriceVanVeen
force-pushed
the
maurice/fix-chkfloor
branch
2 times, most recently
from
4c3bcdf to
9410103
Compare
MauriceVanVeen
force-pushed
the
maurice/fix-chkfloor
branch
from
9410103 to
7cdb600
Compare
MauriceVanVeen
changed the title
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/fix-chkfloor
branch
from
7cdb600 to
0268040
Compare
|
@derekcollison, removed the retry floor from this PR, this is ready for review again. |
MauriceVanVeen
pushed a commit
that referenced
this pull request
Nov 21, 2024
`o.chkflr` was set to be too high, whereas it should never be higher than `o.asflr+1`. If `o.chkflr > o.asflr+1` we're not able to retry acking messages until `o.asflr` is upped. Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
o.chkflrwas set to be too high, whereas it should never be higher thano.asflr+1. Ifo.chkflr > o.asflr+1we're not able to retry acking messages untilo.asflris upped.Signed-off-by: Maurice van Veen github@mauricevanveen.com