Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Memory stream compact should clear subjects state & hold write lock #6187

Merged
merged 2 commits into from
Nov 28, 2024
Merged

[FIXED] Memory stream compact should clear subjects state & hold write lock #6187

merged 2 commits into from
Nov 28, 2024

Conversation

MauriceVanVeen
Copy link
Member

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen
[FIXED] Hold write lock during ms.SubjectsState
4b06cb9 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen
[FIXED] Memory stream compact should clear subjects state
9042ba3 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner November 28, 2024 16:11
neilalexander
neilalexander approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wallyqs
wallyqs approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

derekcollison
derekcollison approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 9c2061e into main Nov 28, 2024
5 checks passed
@derekcollison derekcollison deleted the maurice/mem-compact-clear-fss branch November 28, 2024 17:28
@neilalexander neilalexander mentioned this pull request Dec 2, 2024
Merged
neilalexander added a commit that referenced this pull request Dec 2, 2024
@neilalexander
Cherry-picks for 2.10.23-RC.8 (#6195)
226c595 
Includes:

- #6187
- #6174
- #6189
- #6192

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

@derekcollison derekcollison derekcollison approved these changes

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MauriceVanVeen @wallyqs @derekcollison @neilalexander