Reduce size of meta snapshots further #6189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…napshots Signed-off-by: Neil Twigg <neil@nats.io>
… stream assignment Signed-off-by: Neil Twigg <neil@nats.io>
derekcollison
approved these changes
Nov 29, 2024
neilalexander
added a commit
that referenced
this pull request
Dec 2, 2024
neilalexander
added a commit
that referenced
this pull request
Dec 3, 2024
This was changed in #6189 but we need it to be in the snapshot after all in order to be able to safely roll back to earlier versions. Signed-off-by: Neil Twigg <neil@nats.io>
derekcollison
added a commit
that referenced
this pull request
Dec 3, 2024
neilalexander
added a commit
that referenced
this pull request
Dec 3, 2024
This was changed in #6189 but we need it to be in the snapshot after all in order to be able to safely roll back to earlier versions. Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would not expect to respond to a consumer assignment after, e.g. a restart, and we don't store these for stream assignments already, therefore the
subjectandreplyfields do not need to be encoded for consumer assignments either.Similarly, the
streamname doesn't need to be repeated for each consumer assignment either, as we can just pull that out of the parent stream assignment when decoding, so don't encode that either.This should further reduce the size of meta snapshots and, with it, reduce their encoding/decoding time.
Signed-off-by: Neil Twigg neil@nats.io