#57 new cli flag save single snapshot to file #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() into kibibytes, mebibytes, kibibytes which are well-known, human-readable units of measurement
…able - the if-else structure was not really needed and it has been simplified to use plain 'ifs' - the "NA" case at the bottom would never be reached because all possible cases are already covered from a numerical perspective
…inted in raw bytes
…y-raw-bytes ksidirop/NTOP 0053 flag to display raw bytes
… t.Run() instead of raw tests
…y-raw-bytes clean (Psize unit tests): refactor the test harness to have it employ t.Run() instead of raw tests
… t.Run() instead of raw tests
…idirop/NTOP-0053-flag-to-display-raw-bytes
…y-raw-bytes nats-io#53 new cli-flag '-b' to display raw bytes
- consolidate 1024-related constants used in Psize() into kibibytes, mebibytes, kibibytes which are well-known, human-readable units of measurement - the if-else structure was not really needed and it has been simplified to use plain 'ifs' - the "NA" case at the bottom would never be reached because all possible cases are already covered from a numerical perspective - neutral cleanups in Psize() to make it more readable - refactor the test harness to have it employ t.Run() instead of raw tests
…tes-flag ksidirop/NTOP 0053 support raw bytes flag
* 'main' of github.com:nats-io/nats-top: Add Raw bytes toggle (nats-io#55) nats-io#53 add -b flag to display traffic in raw bytes (nats-io#54)
…each redraw with this change we can support the new '-r N' flag to exit upon refreshing N times
…r of times nats-top should refresh nats-stats before exiting
…hing-N-times Ksidirop/ntop 0052 support refreshing n times
…tats() to fetch new nats-stats
…ave-single-snapshot-to-file $57 new cli flag save single snapshot to file
…ave-single-snapshot-to-file feat (cli flag '-o -'): passing '-o -' now prints the snapshot to the…
…ported as they used to
|
I think functionality looks good, could you rebase the branch on top of main to be able to merge? |
…TOP-0057-new-cli-flag-save-single-snapshot-to-file * 'master' of github.com:dsidirop/nats-top:
…-0057-new-cli-flag-save-single-snapshot-to-file * 'main' of github.com:nats-io/nats-top: nats-io#52 support refreshing N times (nats-io#56) # Conflicts: # nats-top.go # readme.md
|
Thank you for the prompt follow-up. I've resolved conflicts but not sure if that's enough - please let me know if there are additional steps that I must undertake @wallyqs |
|
Thanks @dsidirop! I will do a release soon with your changes. |
dsidirop
deleted the
ksidirop/NTOP-0057-new-cli-flag-save-single-snapshot-to-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wallyqs
Let me know what you think. I'm only 90% sure that this fits the bill.
Any feedback welcome - Thank you in advance!