Naturalis #52
Merged
Naturalis #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YAML and CSV are optional
merge triage
…t word of the fasta definition line. The process ID is attached to the record under sequence.annotations[bcdm_fields][processid]
…cess ID as a separate member of the return tuple, but rather attaches it to the sequence under sequence.annotations[bcdm_fields][processid]
…cess ID as a separate member of the return tuple, but rather attaches it to the sequence under sequence.annotations[bcdm_fields][processid]. Also, both the structural validation and the taxonomic validation now both receive a result object that they modify.
…D as a separate member of the return tuple, but rather attaches it to the sequence under sequence.annotations[bcdm_fields][processid]. Also, both the structural validation and the taxonomic validation now both receive a result object that they modify.
… ID. Also has getters/setters for the fasta file name ('dataset'). Separate handling of 'level' is now handled by 'identification_rank'. The column headers are managed such that they can be flushed from one result set to the next.
…() and the DNAAnalysisResult constructor.
… res.dataset field
…etically we could now validate different records at different precision levels.
…sequence character :-/
Recent changes to sequence_id bookkeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.