Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to provide secretKey via reference #283

Closed
BlackDark opened this issue Jun 5, 2023 · 4 comments
Closed

Add ability to provide secretKey via reference #283

BlackDark opened this issue Jun 5, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers status: accepted This issue has been accepted by the maintainers team for implementation

Comments

@BlackDark
Copy link
Contributor

Currently only directly supported via setting plain value in values file.

@nniehoff
Copy link
Contributor

nniehoff commented Jun 5, 2023

@BlackDark have an example of what you are looking for?

@BlackDark
Copy link
Contributor Author

BlackDark commented Jun 5, 2023

Yes, similar to the db password etc.

nautobot:
	secretKey:
		existingSecret: name-of-secret
		existingSecretKey: key

# currently only this option works
nautobot:
	secretKey: blablamagicsecret
# could go via sops and encrypt the file / value but why not using existing kubernetes features

@nniehoff
Copy link
Contributor

nniehoff commented Jun 5, 2023

ah ok, I think I'm following that is the secret key for django to be passed to Nautobot... I had my head stuck on a kubernetes secret and key... more coffee helped... Yeah this is a good and simple add thanks for the suggestion...

@nniehoff nniehoff added enhancement New feature or request good first issue Good for newcomers status: accepted This issue has been accepted by the maintainers team for implementation labels Jun 5, 2023
cardoe added a commit to cardoe/helm-charts that referenced this issue Jan 27, 2024
Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.
cardoe added a commit to cardoe/helm-charts that referenced this issue Jan 27, 2024
Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.
cardoe added a commit to cardoe/helm-charts that referenced this issue Jan 27, 2024
Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.
cardoe added a commit to cardoe/helm-charts that referenced this issue Jan 29, 2024
Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.
cardoe added a commit to cardoe/helm-charts that referenced this issue Feb 4, 2024
Utilize the Redis password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.
cardoe added a commit to cardoe/helm-charts that referenced this issue Feb 16, 2024
Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.
cardoe added a commit to cardoe/helm-charts that referenced this issue Feb 16, 2024
Utilize the Redis password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.
cardoe added a commit to cardoe/helm-charts that referenced this issue Feb 20, 2024
Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.
cardoe added a commit to cardoe/helm-charts that referenced this issue Feb 20, 2024
Utilize the Redis password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.
cardoe added a commit to cardoe/helm-charts that referenced this issue Feb 20, 2024
Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.
cardoe added a commit to cardoe/helm-charts that referenced this issue Feb 20, 2024
Utilize the Redis password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.
cardoe added a commit to cardoe/helm-charts that referenced this issue Feb 21, 2024
Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.
cardoe added a commit to cardoe/helm-charts that referenced this issue Feb 21, 2024
Utilize the Redis password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.
cardoe added a commit to cardoe/helm-charts that referenced this issue Feb 26, 2024
Utilize the Redis password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.
ubajze pushed a commit that referenced this issue Feb 26, 2024
* allow providing DB password via secret ref

Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing #355 and allows references, fixing #283.

* allow providing Redis password via secret ref

Utilize the Redis password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing #355 and allows references, fixing #283.
@ubajze
Copy link
Contributor

ubajze commented May 28, 2024

Hello @BlackDark. This is now supported from the release 2.1.0 (https://docs.nautobot.com/projects/helm-charts/en/stable/advanced-features/existing-secrets/).

I am closing the issue. If you find that the behavior is not what you expected, feel free to open a new issue.

@ubajze ubajze closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers status: accepted This issue has been accepted by the maintainers team for implementation
Projects
None yet
Development

No branches or pull requests

3 participants