New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm template command fails #355

Closed

cardoe opened this issue Jan 26, 2024 · 2 comments · Fixed by #364

Contributor

cardoe commented Jan 26, 2024

When using helm template locally or via ArgoCD it fails due to the comments posted on #249.

error: Error: execution error at (nautobot/templates/secret.yaml:17:4): Existing Nautobot DB secret 'my-existing-secret' not found!

But I can confirm the secret is there.

The text was updated successfully, but these errors were encountered:

cardoe added a commit to cardoe/helm-charts that referenced this issue


          allow providing DB password via secret ref

909a15c

Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.

cardoe mentioned this issue

allow providing passwords via secret ref #356

Merged

cardoe added a commit to cardoe/helm-charts that referenced this issue


          allow providing DB password via secret ref

40fe19a

Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.

cardoe added a commit to cardoe/helm-charts that referenced this issue


          allow providing DB password via secret ref

1c09757

Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.

cardoe added a commit to cardoe/helm-charts that referenced this issue


          allow providing DB password via secret ref

fb13d07

Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.

cardoe added a commit to cardoe/helm-charts that referenced this issue


          allow providing Redis password via secret ref

0d77e68

Utilize the Redis password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.

cardoe added a commit to cardoe/helm-charts that referenced this issue


          allow providing DB password via secret ref

3c169a4

Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.

cardoe added a commit to cardoe/helm-charts that referenced this issue


          allow providing Redis password via secret ref

f57789c

Utilize the Redis password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.

cardoe added a commit to cardoe/helm-charts that referenced this issue


          allow providing DB password via secret ref

4fedbbd

Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.

cardoe added a commit to cardoe/helm-charts that referenced this issue


          allow providing Redis password via secret ref

4c2671a

Utilize the Redis password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.

cardoe added a commit to cardoe/helm-charts that referenced this issue


          allow providing DB password via secret ref

182983a

Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.

cardoe added a commit to cardoe/helm-charts that referenced this issue


          allow providing Redis password via secret ref

a26a81f

Utilize the Redis password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.

cardoe added a commit to cardoe/helm-charts that referenced this issue


          allow providing DB password via secret ref

6478edb

Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.

cardoe added a commit to cardoe/helm-charts that referenced this issue


          allow providing Redis password via secret ref

15ad42a

Utilize the Redis password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.

cardoe added a commit to cardoe/helm-charts that referenced this issue


          allow providing Redis password via secret ref

3e37842

Utilize the Redis password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing nautobot#355 and allows references, fixing nautobot#283.

ubajze pushed a commit that referenced this issue


          allow providing passwords via secret ref (#356)

d18cac3

* allow providing DB password via secret ref

Utilize the DB password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing #355 and allows references, fixing #283.

* allow providing Redis password via secret ref

Utilize the Redis password supplied from the k8s secret reference instead
of copying it into a Nautobot specific secret. This fixes issues with
"helm template", fixing #355 and allows references, fixing #283.

Contributor

m4rg4sh commented Feb 28, 2024

Thank you so much for your work, we've hit the same issue pretty much on the day you opened your issues.
I've tried your contributed code yesterday and I have found two issues with it:

a) Your reference for .Values.postgresql.auth.secretsKeys.adminPasswordKey has a typo which conflicts with the postgresql subchart (secretsKeys vs secretKeys) and also references the admin password where instead it should use the user password.

b) Your solution conflicts with the documented usage of preexisting secrets. If used as documented in the top half (without specifying nautobot.db.existingSecret) it will actually overwrite any existing password in the referenced secret with empty string.

I've written a fix for both issues and will open a PR for it in a moment.
I've tested it with the postgresql but I think it should just as well work with mariadb or postgresqlha.

Again thank you so much for you work, you saved me a lot of headaches 👍

m4rg4sh mentioned this issue

Fix use of existing secrets #364

Merged

Contributor Author

cardoe commented Feb 28, 2024

Apologies for the mistakes and thank you for creating a PR as a follow up.

cardoe closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment