Fix use of existing secrets #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you happen to run the validation commands from #356 locally? Cause I think that’ll help this land quicker. |
|
@cardoe not locally but I ran the CI workflow in my fork and the relevant steps seem to succeed |
|
@ubajze i think this would probably be good to get into the release you are working on. |
|
I will try to finish this work next week if time permits. |
|
Looks like this passed the expected tests. |
ubajze
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #355 #356
Uses the user password instead of the admin password and removes the necessity to specify nautobot.db.existingSecret if postgresql.auth.existingSecret is already specified as described in #355 and also relating to #356.