Merge pull request #199 from nautobot/bug_fix_serial_number_schema

Fix error if Serial # is only numbers.
nautobot · Aug 1, 2024 · 86b3d69 · 86b3d69
2 parents ef755f6 + 0afb3d0
commit 86b3d69
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/nautobot_device_onboarding/command_mappers/cisco_ios.yml b/nautobot_device_onboarding/command_mappers/cisco_ios.yml
@@ -11,6 +11,7 @@ sync_devices:
         parser: "textfsm"
         jpath: "[*].serial[]"
         post_processor: "{{ obj | unique | first }}"
+        iterable_type: "str"
   device_type:
     commands:
       - command: "show version"
@@ -46,6 +47,7 @@ sync_network_data:
         parser: "textfsm"
         jpath: "[*].serial[]"
         post_processor: "{{ obj | unique | first }}"
+        iterable_type: "str"
   interfaces:
     root_key: true
     commands:

diff --git a/nautobot_device_onboarding/nornir_plays/schemas.py b/nautobot_device_onboarding/nornir_plays/schemas.py
@@ -11,7 +11,7 @@ def sync_devices_schema(json_schema=True):
             "required": ["hostname", "serial", "device_type", "mgmt_interface", "platform", "network_driver"],
             "properties": {
                 "hostname": {"type": "string", "description": "Hostname of the network device"},
-                "serial": {"type": "string", "description": "Serial number of the network device"},
+                "serial": {"type": ["string", "integer"], "description": "Serial number of the network device"},
                 "device_type": {"type": ["string", "integer"], "description": "Type of the network device"},
                 "mgmt_interface": {"type": "string", "description": "Management interface of the network device"},
                 "mask_length": {
@@ -127,7 +127,7 @@ def sync_network_data_schema(json_schema=True):
     "required": ["serial", "hostname", "device_type", "mgmt_interface", "mask_length"],
     "properties": {
         "serial": {
-            "type": "string",
+            "type": ["string", "integer"],
             "description": "Serial number of the network device",
             "minItems": 1,
         },
@@ -145,7 +145,7 @@ def sync_network_data_schema(json_schema=True):
     "required": ["serial", "interfaces"],
     "properties": {
         "serial": {
-            "type": "string",
+            "type": ["string", "integer"],
             "description": "Serial number of the network device",
             "minItems": 1,
         },