Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error if Serial # is only numbers. #199

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

zackt25
Copy link
Contributor

@zackt25 zackt25 commented Jun 28, 2024

Found that after fixes were done for device types that only had integers I ran into the error again but it was for a serial # that only had integers. I copied what was done for the fix for device type.

@zackt25 zackt25 requested review from jeffkala and susanhooks and removed request for glennmatthews, scetron, chadell and mzbroch June 28, 2024 00:08
@zackt25
Copy link
Contributor Author

zackt25 commented Jun 28, 2024

I was thinking about adding it to hostname but didn't know if it would work due to serial and device type having the [] at the end of the jpath. I know that someone will have a hostname that is just an integer.

@scetron scetron merged commit 86b3d69 into prep-4.0.0 Aug 1, 2024
15 checks passed
@scetron scetron deleted the bug_fix_serial_number_schema branch August 1, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants