Add version constraint to divide into two release trains 1.x and 2.x #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanderaa
approved these changes
Jul 11, 2023
joewesch
reviewed
Jul 27, 2023
joewesch
approved these changes
Aug 1, 2023
pszulczewski
added a commit
that referenced
this pull request
Oct 24, 2023
* fix: Update methods for custom fields (#114) Add method `custom_field_choices()` in `App` class. Rename method `custom_choices()` to `custom_fields()`. Update docstings for both methods according to returning data. * fix: Tests for methods for custom fields (#114) Add test case `AppCustomFieldChoicesTestCase` for `custom_field_choices()` method. Rename test case for `custom_fields()` method. Add using fixtures for mentioned test cases. * fix: Fixtures for tests (custom fields) (#114) Add missing JSON files with fixtures for tests for getting custom fields. * fix: Failing test for getting custom fields (#114) Fix test cases `AppCustomFieldsTestCase` and `AppCustomFieldChoicesTestCase` for python 3.7 stable. Update logic for checking passed arguments of mock's `call_args`. * Update api.py * max_workers added * max_workers added * Update query.py * Update query.py * max_workers from api to request * debug removed * Update api.py * Update query.py * refactor: Update docstrings and naming (#114) * (docs) update docstrings for `custom_fields()` and `custom_field_choices()` methods * (refactor): use f-strings instead of `.format()` in `custom_fields()` and `custom_field_choices()` * (tests): update naming in tests * (tests): use `return_value` instead of `side_effect` for mocks * fix: backward compatibility * (fix): restore original method `custom_choices()` for application class to provide a compatibility with existing client code * (enhance): add logging a deprecation warning * refactor: update `custom_choices()` (#114) * (refactor): call `custom_fields()` in `custom_choices()` since they represent essentially identical requests to Nautobot * Add version constraint to divide into two release trains 1.x and 2.x (#130) Add version constraint to divide into two release trains 1.x and 2.x * Release 2.0 (#136) * Release 2.0.0 --------- Co-authored-by: Jan Snasel <jan.snasel@networktocode.com> Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com> * Fix SSL verify (#140) (#142) * Fix custom_fields and custom_field_choices method overlap with endpoints (#141) (#144) * Release 2.0.1 --------- Co-authored-by: nautics889 <cyberukr@gmail.com> Co-authored-by: NobodyIsPerfect78 <46317624+NobodyIsPerfect78@users.noreply.github.com> Co-authored-by: Josh VanDeraa <jv@networktocode.com> Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com> Co-authored-by: Jan Snasel <jan.snasel@networktocode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.