Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambiguity of getting elements #467

Closed
netil opened this issue Mar 6, 2017 · 2 comments
Closed

Ambiguity of getting elements #467

netil opened this issue Mar 6, 2017 · 2 comments
Assignees
@sculove
Labels
bug infiniteGrid

Comments

@netil
Copy link
Member

netil commented Mar 6, 2017

Description

Getting top/bottom elements API description and return value has ambiguity.

Returns a card element at the top of a layout.

Returns a card element at the bottom of a layout.

The descriptions are likely saying getting result of top or last element, but if grids are divided in several columns, which one is the expected?

For example, in the following case, .getBottomElement(), return the right element? or the left?

image
@sculove
Copy link
Contributor

sculove commented Mar 6, 2017

I will add jsdoc comment.

@sculove
Copy link
Contributor

sculove commented Mar 6, 2017

The last element is used to find the index of the next data to fetch.
we should fix it.

@sculove sculove added the bug label Mar 6, 2017
sculove added a commit to sculove/egjs that referenced this issue Mar 7, 2017
@sculove
fix(infiniteGrid): fix return value of getBottomElement
9bdd290 
- add comment

ref naver#467
@sculove sculove mentioned this issue Mar 7, 2017
Merged
@sculove sculove closed this as completed in 64bdb65 Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sculove sculove

Labels
bug infiniteGrid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sculove @netil