fix(infiniteGrid): fix return value of getBottomElement #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add comment ref naver#467
netil
suggested changes
Mar 7, 2017
src/infiniteGrid.js
Outdated
| @@ -425,15 +425,15 @@ eg.module("infiniteGrid", ["jQuery", eg, window, document], function($, ns, glob | |||
| * @ko 레이아웃의 맨 아래에 있는 카드 엘리먼트를 반환한다. | |||
| * @method eg.InfiniteGrid#getBottomElement | |||
| * | |||
| * @return {HTMLElement} Card element at the bottom of a layout <ko>레이아웃의 맨 아래에 있는 카드 엘리먼트</ko> | |||
| * @return {HTMLElement} Card element at the bottom of a layout (f the position of card element is same, returns right element)<ko>레이아웃의 맨 아래에 있는 카드 엘리먼트 (카드의 위치가 같은 경우, 오른쪽 엘리먼트가 반환된다)</ko> | |||
There was a problem hiding this comment.
if the position of card elements are same, it returns the last right element
src/infiniteGrid.js
Outdated
| @@ -395,7 +395,7 @@ eg.module("infiniteGrid", ["jQuery", eg, window, document], function($, ns, glob | |||
| * @ko 레이아웃의 맨 위에 있는 카드 엘리먼트를 반환한다. | |||
| * @method eg.InfiniteGrid#getTopElement | |||
| * | |||
| * @return {HTMLElement} Card element at the top of a layout <ko>레이아웃의 맨 위에 있는 카드 엘리먼트</ko> | |||
| * @return {HTMLElement} Card element at the top of a layout. (if the position of card element is same, returns left element) <ko>레이아웃의 맨 위에 있는 카드 엘리먼트 (카드의 위치가 같은 경우, 왼쪽 엘리먼트가 반환된다)</ko> | |||
There was a problem hiding this comment.
if the position of card elements are same, it returns the first left element
netil
approved these changes
Mar 7, 2017
malangfox
pushed a commit
that referenced
this pull request
Jan 6, 2025
* fix(infiniteGrid): fix return value of getBottomElement close #467 * skip: apply review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#467
Details
Preferred reviewers
@netil