Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/dropdown voice over bug #2303

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Conversation

it-vegard
Copy link
Contributor

Description

Fix VoiceOver navigation issue inside Popover (and through inheritance in Dropdown, Datepicker and Timeline)

Change summary

  • Removed tabIndex="-1" on Popover, as it seems to break something™️ without appearing to be used for anything useful.

…e navigation inside the Popover doesn't work.

This affects Datepicker, Dropdown, Timeline and the Popover components, but appears to cause no bugs.

Ref: https://nav-it.slack.com/archives/C7NE7A8UF/p1694158816166729
@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2023

🦋 Changeset detected

Latest commit: 3d04aef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch
@navikt/aksel Patch
@navikt/aksel-stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Storybook demo

f37d3b956 | 58 komponenter | 374 stories

@it-vegard it-vegard marked this pull request as draft September 20, 2023 13:43
…own tabIndex="-1", which we need to get rid of.
@it-vegard it-vegard marked this pull request as ready for review September 21, 2023 06:24
@KenAJoh
Copy link
Collaborator

KenAJoh commented Sep 22, 2023

Prøvde å grave litt i hvorfor tabIndex er satt til -1 i floatingUi-koden, men fant ingenting konkret. Har en mistanke om at det bare er satt til default siden de har løsninger som kan nestes og da bytter mellom tabIndex -1 og 0 for rowing tabindex.
https://github.com/search?q=repo%3Afloating-ui%2Ffloating-ui%20tabIndex&type=code

@KenAJoh
Copy link
Collaborator

KenAJoh commented Sep 22, 2023

Screen.Recording.2023-09-22.at.09.59.57.mov

Skjer noe rart med Timeline-popover og interaktive elementer. Virker som klikk ikke alltid blir capturet ved klikk på både knapp og utenfor knapp 🤔
Er testet på ContentDemo for Timeline + {p.children} <button>tstknapp</button>

JulianNymark
JulianNymark previously approved these changes Sep 22, 2023
…on, reducing the amount of code we need to change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants