Bugfix/prevent submit on enter in combobox #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9b1c8b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demobbe0620b6 | 61 komponenter | 202 stories |
KenAJoh
previously approved these changes
Apr 17, 2024
There was a problem hiding this comment.
🚀 Ser ut til å fungere bra 🚀
Bare et åpent sprøsmål, men bør enter i teorien submitte form så lenge Enter ikke har en annen handling? Så i tilfellene
- Input er tomt, popover er lukket
- Du har valgt et element (f.eks banana), og trykker så enter etter det
- Autocomplete er tomt, popover er lukket etc
- Sikkert flere caser
Blir raskt en ganske kompleks sjekk onEnter, så kanskje aller enkleste er å bare ignorere disse edgecasene og bare kjøre på med foreslått løsning i PR-en
…ot submitting the form
…other action (like selecting an option)
… to the chips in the previous step
… open/close button didn't work
KenAJoh
reviewed
Apr 17, 2024
@navikt/core/react/src/form/combobox/SelectedOptions/SelectedOptions.tsx
Outdated
Show resolved
Hide resolved
…side effects, but we need to remove virtual focus at least. That way we won't double-click on enter.
…eed to click the toggleIsOpen button to check that the option is un-selected
KenAJoh
reviewed
Apr 18, 2024
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Presently, pressing enter inside of Combobox will trigger onSubmit if it is inside of a form (as it should be).
Fixed #2808
Change summary
Preventing submit on Enter-presses inside of Combobox.