Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

navikt / aksel Public

Notifications You must be signed in to change notification settings
Fork 42
Star 157

Code
Issues 34
Pull requests 10
Discussions
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Security
Insights

Bugfix/prevent submit on enter in combobox#2861

Merged

it-vegard merged 18 commits intomainnavikt/aksel:mainfrom bugfix/prevent-submit-on-enter-in-comboboxnavikt/aksel:bugfix/prevent-submit-on-enter-in-comboboxCopy head branch name to clipboard

Apr 18, 2024

+87-1

Conversation Commits18 (18)Checks Files changed

Commits

Commits on Apr 17, 2024

Prevent "Enter" key in Combobox to...
it-vegard
committed
Added test for Enter not submitting form
it-vegard
committed
Added changeset
it-vegard
committed
Add test for un-selecting a selected option using "enter" on a Chip not submitting the form
it-vegard
committed
Do not prevent enter from submitting form if it should not perform another action (like selecting an option)
it-vegard
committed
Do not submit when the input field has a value
it-vegard
committed
Replace lots of sleep-calls with awaiting userEvents
it-vegard
committed
Create util function for looking up an option
it-vegard
committed
Fix bug where we couldn't un-select a custom option using "enter"
it-vegard
committed
Merge branch 'main' into bugfix/prevent-submit-on-enter-in-combobox
it-vegard
authored
Update test to account for the dropdown list closing when focus moves to the chips in the previous step
it-vegard
committed
Add possibility to slow down tests for debugging
it-vegard
committed
Fix issue with onFocus -> onToggleSelected(false), where clicking the open/close button didn't work
it-vegard
committed
Fix test
it-vegard
committed

Commits on Apr 18, 2024

Closing the FilteredOptionsList when focusing a Chip caused too many side effects, but we need to remove virtual focus at least. That way we won't double-click on enter.
it-vegard
committed
When no longer closing FilteredOptions on focusing a chip, we don't need to click the toggleIsOpen button to check that the option is un-selected
it-vegard
committed
Update .changeset/rotten-windows-cover.md

it-vegard
and
KenAJoh
authored
Merge branch 'main' into bugfix/prevent-submit-on-enter-in-combobox
it-vegard
authored

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.