Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] 🐛 Focus-border no longer cancels out error-border. #3465

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Dec 17, 2024

Description

https://nav-it.slack.com/archives/C7NE7A8UF/p1734441582223079

After
Screenshot 2024-12-17 at 14 43 09

Before
Screenshot 2024-12-17 at 14 43 18

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: 5b52756

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-css Patch
@navikt/aksel-stylelint Patch
@navikt/aksel Patch
@navikt/ds-react Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 17, 2024

Storybook demo

35f03c0e0 | 91 komponenter | 135 stories

@KenAJoh KenAJoh changed the title 🐛 Focus-border no longer cancels out error-border. [Select] 🐛 Focus-border no longer cancels out error-border. Dec 17, 2024
@KenAJoh KenAJoh enabled auto-merge (squash) December 19, 2024 14:24
@KenAJoh KenAJoh merged commit 0017789 into main Dec 19, 2024
4 checks passed
@KenAJoh KenAJoh deleted the select-error-focus branch December 19, 2024 16:20
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants