Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] 🐛 Focus-border no longer cancels out error-border. #3465

Merged
merged 3 commits into from
Dec 19, 2024
Merged

[Select] 🐛 Focus-border no longer cancels out error-border. #3465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49ec3e2
:bug: Focus-border no longer cancels out error-border.
KenAJoh Dec 17, 2024
655efc1
:recycle: Optimize CSS selectors, fix textarea
KenAJoh Dec 19, 2024
5b52756
:memo: Changeset
KenAJoh Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/late-turkeys-drive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@navikt/ds-css": patch
---

Select: :bug: Focus-border no longer cancels out error-border.
5 changes: 5 additions & 0 deletions .changeset/young-goats-smash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@navikt/ds-css": patch
---

Textarea: :bug: Focus-border no longer cancels out error-border.
6 changes: 5 additions & 1 deletion @navikt/core/css/form/select.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,15 @@
/**
Error handling
*/
.navds-select--error > * select:not(:hover, :focus, :disabled) {
.navds-select--error > * .navds-select__input:not(:hover, :disabled) {
box-shadow: 0 0 0 1px var(--ac-select-error-border, var(--a-surface-danger));
border-color: var(--ac-select-error-border, var(--a-surface-danger));
}

.navds-select--error .navds-select__input:focus {
box-shadow: var(--a-shadow-focus);
}

/**
Disabled
*/
Expand Down
9 changes: 3 additions & 6 deletions @navikt/core/css/form/textarea.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,16 +111,13 @@
/**
Error handling
*/
.navds-textarea--error .navds-textarea__input:not(:hover, :focus-visible, :disabled) {
.navds-textarea--error .navds-textarea__input:not(:hover, :disabled) {
box-shadow: 0 0 0 1px var(--ac-textarea-error-border, var(--__ac-textarea-error-border, var(--a-border-danger)));
border-color: var(--ac-textarea-error-border, var(--__ac-textarea-error-border, var(--a-border-danger)));
}

@supports not selector(:focus-visible) {
.navds-textarea--error .navds-textarea__input:not(:hover, :focus, :disabled) {
box-shadow: 0 0 0 1px var(--ac-textarea-error-border, var(--__ac-textarea-error-border, var(--a-border-danger)));
border-color: var(--ac-textarea-error-border, var(--__ac-textarea-error-border, var(--a-border-danger)));
}
.navds-textarea--error .navds-textarea__input:focus-visible {
box-shadow: var(--a-shadow-focus);
}

.navds-textarea__input:disabled {
Expand Down
Loading