Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Return http delete, batch and patch responses #13

Merged
merged 5 commits into from
Dec 13, 2022

Conversation

syphax-bouazzouni
Copy link

The issue

the delete, batch, and patch were returning nil and not the API response

before (e.g delete)

 def self.delete(id)
        puts "Deleting #{id}" if $DEBUG
        response = conn.delete id
        raise StandardError, response.body if response.status >= 500
      end

after (e.g delete)

 def self.delete(id)
        puts "Deleting #{id}" if $DEBUG
        response = conn.delete id
        raise StandardError, response.body if response.status >= 500
       
        response
      end

@syphax-bouazzouni
Copy link
Author

Hi @jvendetti,
I suggest you revert this PR or accept this ncbo/bioportal_web_ui#240 otherwise the update/create actions of the UI will not behave as expected. (sorry I figured this out lately)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants