Fix: Return http delete, batch and patch responses

Gemfile.lock

@@ -59,6 +59,7 @@ PLATFORMS
   ruby
   x86_64-darwin-16
   x86_64-darwin-17
+  x86_64-linux
 
 DEPENDENCIES
   ontologies_api_client!

lib/ontologies_api_client/http.rb

@@ -19,6 +19,7 @@ def members
   def length
     @table.keys.length
   end
+
   alias :size :length
 
   def to_a
@@ -37,7 +38,9 @@ def values_at(*selectors)
 module LinkedData
   module Client
     module HTTP
-      class Link < String; attr_accessor :media_type; end
+      class Link < String
+        attr_accessor :media_type;
+      end
 
       def self.conn
         unless LinkedData::Client.connection_configured?
@@ -53,7 +56,7 @@ def self.conn
       def self.get(path, params = {}, options = {})
         headers = options[:headers] || {}
         raw = options[:raw] || false # return the unparsed body of the request
-        params = params.delete_if {|k,v| v == nil || v.to_s.empty?}
+        params = params.delete_if { |k, v| v == nil || v.to_s.empty? }
         params[:ncbo_cache_buster] = Time.now.to_f if raw # raw requests don't get cached to ensure body is available
         invalidate_cache = params.delete(:invalidate_cache) || false
 
@@ -83,7 +86,7 @@ def self.get(path, params = {}, options = {})
           else
             obj = recursive_struct(load_json(response.body))
           end
-        rescue Exception => e
+        rescue StandardError => e
           puts "Problem getting #{path}" if $DEBUG
           raise e
         end
@@ -94,12 +97,12 @@ def self.get_batch(paths, params = {})
         responses = []
         if conn.in_parallel?
           conn.in_parallel do
-            paths.each {|p| responses << conn.get(p, params) }
+            paths.each { |p| responses << conn.get(p, params) }
           end
         else
           responses = threaded_request(paths, params)
         end
-        return responses
+        responses
       end
 
       def self.post(path, obj, options = {})
@@ -108,11 +111,12 @@ def self.post(path, obj, options = {})
           req.url path
           custom_req(obj, file, file_attribute, req)
         end
-        raise Exception, response.body if response.status >= 500
+        raise StandardError, response.body if response.status >= 500
+
         if options[:raw] || false # return the unparsed body of the request
-          return response.body
+          response.body
         else
-          return recursive_struct(load_json(response.body))
+          recursive_struct(load_json(response.body))
         end
       end
 
@@ -122,7 +126,8 @@ def self.put(path, obj)
           req.url path
           custom_req(obj, file, file_attribute, req)
         end
-        raise Exception, response.body if response.status >= 500
+        raise StandardError, response.body if response.status >= 500
+
         recursive_struct(load_json(response.body))
       end
 
@@ -132,13 +137,17 @@ def self.patch(path, obj)
           req.url path
           custom_req(obj, file, file_attribute, req)
         end
-        raise Exception, response.body if response.status >= 500
+        raise StandardError, response.body if response.status >= 500
+
+        response
       end
 
       def self.delete(id)
         puts "Deleting #{id}" if $DEBUG
         response = conn.delete id
-        raise Exception, response.body if response.status >= 500
+        raise StandardError, response.body if response.status >= 500
+
+        response
       end
 
       def self.object_from_json(json)
@@ -170,9 +179,11 @@ def self.custom_req(obj, file, file_attribute, req)
 
       def self.params_file_handler(params)
         return if params.nil?
+
         file, return_attribute = nil, nil
         params.dup.each do |attribute, value|
           next unless value.is_a?(File) || value.is_a?(Tempfile) || value.is_a?(ActionDispatch::Http::UploadedFile)
+
           filename = value.original_filename
           file = Faraday::UploadIO.new(value.path, "text/plain", filename)
           return_attribute = attribute
@@ -203,7 +214,7 @@ def self.recursive_struct(json_obj)
           context = json_obj.delete("@context") # strip context
 
           # Create a struct with the left-over attributes to store data
-          attributes = json_obj.keys.map {|k| k.to_sym}
+          attributes = json_obj.keys.map { |k| k.to_sym }
           attributes_always_present = value_cls.attrs_always_present || [] rescue []
           attributes = (attributes + attributes_always_present).uniq
 
@@ -233,7 +244,7 @@ def self.recursive_struct(json_obj)
             end
           else
             # Get the struct class
-            recursive_obj_hash = {links: nil, context: nil}
+            recursive_obj_hash = { links: nil, context: nil }
             json_obj.each do |key, value|
               recursive_obj_hash[key] = recursive_struct(value)
             end
@@ -260,6 +271,7 @@ def self.prep_links(obj)
 
         context = links.delete("@context")
         return if context.nil?
+
         links.keys.each do |link_type|
           link = Link.new(links[link_type])
           link.media_type = context[link_type]
@@ -270,6 +282,7 @@ def self.prep_links(obj)
 
       def self.load_json(json)
         return if json.nil? || json.empty?
+
         begin
           MultiJson.load(json)
         rescue Exception => e