-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zero balance account NEP #448
Conversation
Your Render PR Server URL is https://nomicon-pr-448.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cev4gip4reber7qq1lhg. |
372a4e6
to
2a939f1
Compare
2a939f1
to
79e9121
Compare
7c05fc0
to
87f54d8
Compare
Hi @bowenwang1996 – thank you for starting this proposal. If you believe this NEP is ready for review, please turn the PR into "Ready for review" state and ping the @near/nep-moderators. Once you do that, the moderators will check that the NEP meets all the requirements and will then request the Protocol Working Group to assign 2 technical reviewers. |
Thank you @bowenwang1996 for submitting this NEP. As a moderator, I reviewed this NEP and it meets the proposed template guidelines. I am moving this NEP to the REVIEW stage and would like to ask the @near/wg-protocol working group members to assign 2 Technical Reviewers to complete a technical review (see expectations). If you want to assign yourself, please mention that you are acting as the Technical Reviewers. Please find some guidelines below for completing the technical review. Technical Review Guidelines
Please tag the @near/nep-moderators once you are done, so we can move this NEP to the voting stage. Thanks again. |
Implements near/NEPs#448. Note: this pull request does not update account creation costs. If the NEP is approved, the costs will be updated separately.
Hi @DavidM-D and @mm-near! Thank you for agreeing to review this NEP. Per the NEP workflow, the expectation is for you to complete the review within one week (Tuesday, January 31). Please find additional guidelines below. Technical Review Guidelines
Please tag the @near/nep-moderators once you are done, so we can move this NEP to the voting stage. Thanks again. |
As the moderator, I would like to thank the author @bowenwang1996 for submitting this NEP extension, and @mm-near @DavidM-D @jakmeier and @near/wg-protocol work group members for your review. Based on the voting indications above, and support from @bowenwang1996 it seems like this proposal is close to a decision. We are therefore scheduling the third Protocol Work Group meeting next week, where this NEP can enter the final voting stage. Anyone can discuss the technical details by adding your comments to this discussion. And join the call to learn about the final decision and how to get more involved. Meeting Info |
As a working group member, I lean towards approving this proposal. |
I am in support of this proposal. Agree with the feedback that a UI design to indicate to a user when they are reaching key-limit and need NEAR to continue is needed. Also agree with the feedback that in documentation of using this service there should be clear indication to use it in limited use cases where meta-tx can cover the costs or show a clear on-ramp for earning NEAR. |
Responding to a few concerns mentioned by various people:
|
82 extra bytes, I assume the cost would still be < 7 Tgas, right? That seems completely fine. If the total gas goes above 9Tgas, we have to look into |
If we want to have 4 full access keys, which is 2 more than the current design, then we need to add 164 bytes, which brings the account creation cost to 7.6Tgas |
Oh, I see. 7.6 Tgas is also fine though, I just had to do some more checks. DetailsOnly |
Thank you to everyone who attended the third NEAR Protocol Working Group meeting! The working group members reviewed the NEP and reached the following consensus: Status: Approved
Meeting Recording: @bowenwang1996 Thank you for authoring this NEP! Next Steps:
Implementation Status: Implemented in nearcore, but not yet stabilized |
Update: after a discussion with @k3y0k3y we decided to change the number of full access keys allowed to 4. This increases the account creation cost to 7.6Tgas. As we see in the discussion above, it won't break more contracts. |
Today I learned: Every NEAR token transfer action to an implicit account costs transfer cost + account creation cost + add full access key cost. Even if the account already exists. It makes sense in hindsight, we don't know if the account exists when we send the transfer. And for some reason NEAR uses transfer actions to create implicit accounts instead of create account actions, which I was long aware of. I just didn't connect the dots for what it means for normal transfers. This has two consequences for the zero balance account feature which I haven't realized previously. Maybe the SMEs did think of it already, but to make sure we are not glancing over it, here are the implications:
@bowenwang1996 @mm-near @DavidM-D |
@jakmeier That is a really good call. Exchanges heavily rely on implicit accounts as they own implicit accounts for each user, and now users will pay higher fees to top-up their CEX account balances, and CEX might also use implicit accounts internally for their cold wallets. |
# Feature to stabilize Zero Balance Account that enables a more smooth onboarding experience where users don't have to first acquire NEAR tokens to pay for the storage of their accounts. # Context - NEP: near/NEPs#448 - Implementation: #8378 # Testing and QA - unit tests in runtime/runtime/src/verifier.rs - integration tests in integration-tests/src/tests/client/features/zero_balance_account.rs # Checklist - [x] [Link to nightly nayduck run](https://nayduck.near.org/#/run/2869) - [x] Update CHANGELOG.md to include this protocol feature in the `Unreleased` section.
Updated the spec for zero balance account as per discussion here. @jakmeier I created #462 to document your concern, but as we discussed, it does not seem to be a blocker for this NEP. @firatNEAR we may want to check with partners who manage accounts on users' behalves and often do token transfers to implicit accounts. |
@frol summary of benefits and concerns: Benefits
Concerns
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a NEP moderator, I am approving this PR following the Protocol Work Group approval and the decision context incorporated into the NEP document.
NEP for #415. Implementation can be found in near/nearcore#8378